Repository navigation
fix(fi-instrumentation-otel): keep context helpers attached in async functions - #647
Merged
Merged
Conversation
…functions using_session, using_user, using_attributes and the other context helpers work as decorators. On an async function or async generator they now attach inside the body for its whole execution, with one context token per call and per generator resumption, so concurrent tasks, interleaved generators and exceptions each restore the caller's context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
using_session,using_user,using_attributes,using_metadata,using_tags,using_prompt_template) work as decorators, but on anasync deffunction they attached and detached before the function body ran. Spans created inside async functions got no session or user, so they appeared in no session or the wrong one.What changed
asend,athrow,aclose, cancellation and out-of-order closing are handled.with/async withare unchanged.Verification
Paired run against the previous base on a clean, offline sandbox:
Compatibility
No dependency, version or Python range change. Only
python/fi_instrumentationand its tests change.