Skip to content

fix(fi-instrumentation-otel): trace generator consumption, nullable eval models and session identity - #641

Merged
nik13 merged 1 commit into
devfrom
fix/fi-instrumentation-wave9-on-dev
Nov 12, 2026
Merged

nik13 merged 1 commit into
devfrom
fix/fi-instrumentation-wave9-on-dev

Conversation

@nik13

@nik13 nik13 commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

What was broken

  • Generators returned by traced functions were not followed to the end, so their output, parent and return value were lost.
  • Registering a custom eval model whose fields are empty failed to serialize.
  • Manual session helpers emitted only the conversation id, not the native session id.

What changed

  • Traced generators are followed for their whole lifetime.
  • Custom eval models with empty fields serialize.
  • Session helpers emit the native session id alongside the conversation id.

Verification

On a clean, offline sandbox against the current dev branch:

  • The new regression tests fail on dev without the change and pass with it (54 failing before, 54 passing after; 3 failing before, 6 passing after; 7 failing before, 9 passing after).
  • Package suite: 2952 passed, 0 failed before; 3021 passed, 0 failed after.
  • Dependent package suites run with this core, before and after: openai 1753 -> 1753 passed, 0 failed, langchain 98 -> 98 passed, 0 failed, anthropic 166 -> 166 passed, 0 failed.

Compatibility

No dependency, version or runtime range change. Only the Python core (python/fi_instrumentation) and its tests (python/tests) change.

…val models and session identity

- Trace consumption of generators returned by traced functions.
- Serialize custom eval models whose fields are null.
- Emit the native session identity alongside the conversation id.
@nik13
nik13 merged commit bf899b1 into dev Nov 12, 2026
166 checks passed
@nik13
nik13 deleted the fix/fi-instrumentation-wave9-on-dev branch November 12, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant