Repository navigation
fix(python): require the fi-instrumentation-otel each package's code uses - #634
Merged
Merged
Conversation
…uses Sixteen packages declared a core floor below the names their code reads (most use the SpanAttributes.GEN_AI_* names first shipped in 1.0.0), so an environment that already had an older core failed at import or on the first traced call. Raise each floor to the first core that has every name, refresh the content hash of the seven Poetry locks (no version changes), and add a real-core name check to beeai and strands, whose other tests replace fi_instrumentation with mocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Sixteen Python packages declared a minimum
fi-instrumentation-otelversion lower than the one their code needs. In an environment that already had an older core installed, they failed at import or on the first call, and upgrading the package alone did not upgrade the core.What changed
Verification
Compatibility
Environments that pin an older
fi-instrumentation-otelmust upgrade it to install these package versions.