Repository navigation
fix(ci): align release contracts and preserve audio cache counts - #620
Merged
Merged
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore the six failing TypeScript contract workflows after the zero-code/semantic-conventions release. Keep the stronger privacy contract; fix the confirmed audio-cache-count runtime regression rather than changing its expected count.
Failure analysis and intended behavior
All six baseline runs below failed on dev
2c3a6e8700a0e76b6c8c0c6b820017cffe0c4804before this branch.78ae25ed(#605) defines time-to-first-token semantics;6a3cc768adds its OpenAI stream emission. The same zero-code commit / fi-core CHANGELOG 1.2.0 forbids exporting base64 images. Both changes are intentional.[image-redacted]in all three image-bearing aliases. The request fixture still contains its original image. Run the six-version OpenAI workflow, including packed consumers and the complete OpenAI/core unit suites.6a3cc768introduced shared export privacy and fail-closedredactRequestMetadata: content hiding in either direction projects request/tool metadata to canonical safe fields. Old output-hiding tests expected provider-specifictopP, content-bearingstopSequences, tool descriptions and schemas verbatim.temperatureand tool identity. Keep request non-mutation, unhidden raw input, finish reasons and output secrecy assertions. No privacy allowlist widening. Run SDK 0.1.0 and 0.24.1 against real loopback SDK/OTLP fixtures.6a3cc768: the shared structural-media classifier treatsgen_ai.usage.cache_read_tokens.audio = 2as audio payload because this exact metric key is absent from its scalar catalog. This contradicts the existing modality cost-input contract.6a3cc768removed the project-name override of OTelservice.name.register()still setsproject_name; service identity belongs to OTel resource configuration.project_nameand a deliberately distinctOTEL_SERVICE_NAMEthrough the exact packaged README recipe. Run all six core versions.6a3cc768explicitly export only typedsetSessionidentities; raw session-named attributes remain masked. Codex writes a raw thread-derived attribute. The aggregate failed because this wire assertion failed.setSessionidentity exports. Keep prompt secrecy, usage, parent-child trace identity and HTTP assertions. Do not weaken privacy to re-expose untyped thread IDs. Run the full planned TypeScript integration matrix and aggregate.Latent native-message contract failures
Once the OpenAI snapshots passed, its final
fi-core/test/genai-privacy.test.cjscommand exposed three additional stale expectations from before6a3cc768:An E2B run of the unchanged dev runtime and original test reproduced exactly these three failures (85 passing / 3 failing). With only the revised contract test, the same dev runtime passes all 89 cases, and the direction/credential test also passes on its own.
Runtime and release impact
@traceai/fi-core1.2.1 -> 1.2.2, synchronized in package metadata, release-please manifest and CHANGELOG. fi-core has no separate hard-coded runtime version constant.npm lsrecords the resolved tree. SDK matrix, five repetitions, OS-level network isolation and all assertions remain enabled.Validation receipts
CI for head
9734891d90533f55d2a21fc0a5f5d297671e83bc:Cloud-only causal controls:
fu-dev-ci-audio-count-1108-r1: new focused tests pass 15/15. Replacing only the candidate scalar catalog with dev's catalog yields exactly two failures (numeric preservation with hiding off/on), with the other 13 privacy controls still passing.fu-dev-ci-genai-privacy-1108-r1: original dev native-message contracts fail 3/88; revised contracts pass 89/89 on the same dev runtime; isolated direction/credential test passes 1/1.git diff --check.Review
Self-reviewed the complete final diff against internal minimal-code, typing, failure-mode, PR-review, scenario-testing and API-contract standards, including exact-key admission, secret/media precedence, bounded inputs, repeated export, package resolution and version consistency. No disabled tests or weakened privacy assertions. No unrelated refactors. Human approval and merge remain outstanding; this is deliberately a draft, and no merge or administrative override is requested by this change.
Generated with Claude Code