Repository navigation
Conversation
Preserve FITracer admission and export privacy. Match configured, registered and environment credentials before structural/PII changes, then apply FI policy and keep valid byte-bounded JSON. Inspect complete OpenCode tool inputs rather than cutting at 64 items. Extend the embedding policy to inspect late object discriminators. Co-Authored-By: Claude Code <noreply@anthropic.com>
Fail closed when matching a complete credential removes a JSON key, a media discriminator or source framing. Reuse fi-core hint recognition without importing its exporter into lightweight hook modules. Co-Authored-By: Claude Code <noreply@anthropic.com>
Cover embedded and nested JSON plus array-valued MIME discriminators. A literal credential spanning JSON framing fails closed before island parsing can alter part of the match. Co-Authored-By: Claude Code <noreply@anthropic.com>
Supply the shared discriminator predicate from the full tracer boundary. Lightweight privacy helpers keep their dependency-free startup contract while the sanitizer continues to reuse fi-core recognition. Co-Authored-By: Claude Code <noreply@anthropic.com>
Preserve the process-resource privacy fix and agent workspace builds from dev. Keep fi-core package, manifest, and changelog aligned for the next patch. Co-Authored-By: Claude Code <noreply@anthropic.com>
Include the fi-core build corrections from #619 before repeating the baseline and oversized-content regression proofs. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Defer bounded input, event and turn-owned output content until span finalization so newly registered credentials cannot leave cut prefixes. Distinguish JSON string matches from actual framing overlap, retain public text around punctuation credentials, and cover both regressions on the OTLP wire. Reserve fi-core 1.2.3 after the merged 1.2.2 fixes. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
The inherited 0.1.0 stand-in reports NOT_REGISTERED after the 0.1.1 Codex release. Read the packaged version without weakening the status and doctor assertions. Co-Authored-By: Claude Code <noreply@anthropic.com>
Keep bounded originals in the memory-only observer and seed capture-time credentials; defer PII, credential scrubbing and display shortening to core finalization. The E2B regression exposed late prefixes on all six OTLP surfaces, including a PII-overlap secret. Co-Authored-By: Claude Code <noreply@anthropic.com>
Keep the existing sanitized adapter-to-tracer contract, but perform it only during synchronous emission and retain the complete value for core admission. Do not weaken the recorded native-flow secret assertion. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #608.
Keep oversized coding-agent content readable without losing the complete values needed for privacy checks.
Qualified revision and status
Head:
ca34b9f9e3127bbb2cf41c7935716525c816a3fa.Merged exact current
dev,e4aecfe128e29a942f4f637d39872fc8c355c648, without rebasing, renaming the branch or force-pushing. fi-core is 1.2.3 in its package, release manifest and changelog; the 1.2.1/1.2.2 entries are preserved. This package has no separate runtime version constant.Final E2B qualification passes. GitHub CI is fully green: 121 passed, 13 skipped, no failed or pending checks. The PR remains draft for human/non-author review. No merge, admin override or package publication was performed.
Failing-before / passing-after evidence
Every build/test ran in E2B with whole-repository source stages, synthetic credentials and loopback OTLP collectors; no local tests or customer/provider credentials.
fu608-fix-before-1108a: 22 of the first 29 committed OTLP regressions fail on the pre-fix codefu608-fix-observer-before-1108a: both normal and PII-overlap credentials leak prefixes on all six content surfacesfu608-fix-observer-after-1108band full final run: both cases have zero prefix leaks on all six surfaces; all 42 OpenCode tests pass, including the unchanged recorded-flow privacy assertionfu608-fix-base-1108b: all five failfu608-fix-final-1108b: all five passNOT_REGISTERED: the native CLI stand-in advertises hard-coded 0.1.0 after the 0.1.1 package releaseThe original five assertions pin readable >20,000-character JSON on all five surfaces; byte-bounded multibyte content; no environment-credential prefix at a prose cut; the late embedding discriminator; and complete ordinary 65/100-item OpenCode inputs.
Full final qualification
fu608-fix-final-1108bran the exact pushed source and exited 0:All completed E2B sandboxes were killed and deletion verified with 404. The final source-stage identity receipt verifies that all 20 changed files match the pushed commit byte-for-byte.
Exact commands and receipts
Runner and source:
The runner caps the requested timeout at 55 minutes.
qualify.shrunsreview.sh(frozen pnpm install, dependency-ordered builds, fi-core Jest, all 22 package suites, reviewer matrices and conformance) followed byprove.sh(byte-safe collectors and the five original assertions). The final committed regressions run through normalpnpm --filter @traceai/agent-core testandpnpm --filter @traceai/opencode-v1-plugin testcommands./Volumes/nik-ext-1/tmp/traceai-release-20261104/e2b/runs/fu608-fix-final-1108b/receipt.json./Volumes/nik-ext-1/tmp/traceai-release-20261104/e2b/runs/fu608-fix-base-1108b/receipt.json. Its exit 1 is explicitly attributed to the inherited Codex fixture; the original five proof failures are expected./Volumes/nik-ext-1/tmp/fu608-fix-1108/comparison-final.json./Volumes/nik-ext-1/tmp/fu608-fix-1108/stage-identity.json./Volumes/nik-ext-1/tmp/fu608-fix-1108/(scripts/,base-current-results/,final-results/, and the named before/after result directories).GitHub CI
All 121 passing / 13 skipped checks refer to the qualified head. The required Python tests check passed.
An initially cancelled, not assertion-failing, Codex SDK matrix leg caused its integration aggregate to fail. The targeted rerun and dependent aggregate both passed on attempt 2. There are no remaining CI failures to exempt, and no check or assertion was disabled.
CI snapshots:
/Volumes/nik-ext-1/tmp/fu608-fix-1108/ci-current.jsonandci-integration-rerun.json.Review, limits and rollout
e2e/classifier: not applicable (no harness). Actual OTLP wire exports and cross-agent conformance cover this SDK path. Python lint/migration and frontend-contract gates are not applicable to this diff.🤖 Generated with Claude Code