Repository navigation
Conversation
Honor FI content and error controls across native and FI aliases, scrub credentials, preserve runtime outcomes, and drain conversions before flush or shutdown. Respect environment project routing and classify only actual model calls as LLM observations. Add offline floor/latest SDK contracts and CI. Co-Authored-By: Claude Code <noreply@anthropic.com>
…eAI-494 Co-Authored-By: Claude Code <noreply@anthropic.com>
Cover native request text, structured and error-text credentials, and opt-in shared PII redaction. Classify calls from emitting-runtime feature support, reuse native conversion across mixed peer versions, and emit deterministic integration metadata. Exercise CJS/ESM wire contracts across floor, latest and both mixed SDK sets. Co-Authored-By: Claude Code <noreply@anthropic.com>
Cover AWS credential fields, full cookie headers and nested JSON error serialization. Reconcile remote parents and links with older converters, and classify native workflow control-flow spans. Add failing-first SDK/OTLP contracts and unit coverage. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
…ssors Co-Authored-By: Claude Code <noreply@anthropic.com>
Stage fi-core 1.1.1 for dependency-first release and constrain Mastra to a core build that exports redactPiiInValue. Add a regression guard for the packed dependency floor. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the recall review of #494 and its first two independent reviews. Fix verified runtime and privacy findings without changing the supported Mastra floor or adding another tracer/provider.
FI_PII_REDACTIONwith the existing shared FI PII implementation, including native/FI aliases and error status/events. The shared helper is now exported by@traceai/fi-core; this change must ship through the dependency-first release train with that core change, not as an isolated Mastra publication against the old core artifact.FI_PROJECT_NAME, then serviceName.VERSIONto instrumentation scope andtelemetry.sdk.version.Granular input/message/text/image flags conservatively redact complete duplicated I/O aliases because native and FI blobs do not share a reliable typed schema. Explicit
FI_HIDE_ERROR_DETAILS=falsestill overrides its implied setting.Reproduction and validation
The first follow-up reproduced the five original runtime findings. The independent-review regressions also failed before these corrections: floor 9 failures, latest 8, latest-runtime/floor-converter 9, and floor-observability/latest-converter 9. The failures cover native request text, credential forms, opt-in PII, mixed-version LLM classification and unknown version metadata.
@mastra/core@mastra/observability@mastra/otel-exporterPassing checks:
git diff --checkpasses.origin/devat7cb1d3e42d9e3f80f3f80dc51a87417acdeb0c67; post-merge build, unit tests and release-plan validation passed.Round-two failing-first wire tests reproduced credentials and workflow classification on all four sets (6 failures each) plus missing mixed-version remote parents and links (9 failures in that set). All 17 original independent-review assertions now pass using their unchanged real-SDK/decoded-wire probes. The expanded unit suite first reproduced 14 credential/workflow failures before the implementation changes.
All executable local tests ran in the outbound-network-denied sandbox with synthetic credentials/models and localhost OTLP only. No vendor/Cloud calls, registry publication or workflow dispatch. New-head CI is separate from these local results.
Existing work and scope
The README correction remains in existing open #398 (
fix/mastra-readme-observability); this PR does not duplicate it. That separate PR remains necessary to replace the obsolete imports and telemetry configuration. That PR is being aligned to the restored explicit-option/environment/service project precedence and must ship with this runtime correction.At the earlier review stage, no package versions or release manifests were manually changed. The following release-compatibility follow-up updates fi-core 1.1.1 and its manifest entry. No labels, protected branches, PR merge state or issue state were changed. The earlier nonblocking integration-version metadata finding is now included and fixed.
Additional review follow-up (2026-11-02)
sessionTokenandauth_token, and redact entire signed AWS4-HMAC-SHA256/Digest Authorization values rather than only the scheme. Added failing-first privacy regressions for status, event, and tool error attributes; no mutation of native spans.processor_runspans to CHAIN and assert the kind from real Mastra agent tool execution on the latest runtime.origin/devnormally (no force push). Frozen-lockfile install, release-plan check, build, and Mastra unit suite (93/93) passed. Packed CJS/ESM OTLP contracts passed against peer floor (41 pass, 3 version-specific skips per entrypoint) and latest (44 pass, 0 skips per entrypoint), all in the network-denied sandbox. Real-agent/decoded-OTLP probes for both versions found no synthetic credential leakage; latest emitted four processor spans classified CHAIN.Released-core compatibility follow-up (2026-11-02)
Independent review reproduced zero exported spans when FI_PII_REDACTION=true with published fi-core 1.1.0: that release does not export
redactPiiInValue, while the previously packed Mastra dependency^1.1.0still admitted it. The new failing-first manifest regression rejectedworkspace:^before the fix. This branch stages fi-core 1.1.1 (package and release manifest) and pins Mastra toworkspace:^1.1.1, which packs as^1.1.1and excludes published 1.1.0. This is release preparation, not a claim that 1.1.1 has already been published. The dependency-ordered TypeScript release workflow must publish and verify fi-core 1.1.1 before a new Mastra package version is published; do not publish Mastra independently or reuse its already-published 0.2.1 tarball.Validation: release-plan check passed (129 packages), frozen workspace install and builds passed, fi-core Jest 164/164 and Mastra Jest 94/94 passed. Clean packed consumers with the staged 1.1.1 core passed the real OTLP contracts against Mastra floor (41 pass, 3 version-specific skips) and latest (44 pass, 0 skips). The staged Mastra tarball declares
^1.1.1; 1.1.0 does not satisfy that range. All executable tests ran in the outbound-network-denied sandbox using synthetic credentials and loopback OTLP. No registry publication or workflow dispatch was performed.🤖 Generated with Claude Code