Repository navigation
Conversation
Cover real stable/preview SDKs, preserve aggregate stream lifecycle, repair provider/privacy initialization and owned teardown, and verify packed consumers at both SDK bounds. Co-Authored-By: Claude Code <noreply@anthropic.com>
Normalize string chat parts, prioritize current input turns, retain message envelopes under capture limits, and merge privacy-masked FI context attributes. Add failing-first real-SDK coverage for all four review findings. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Cover positive, zero and absent counters across stable/preview unary and streaming responses at both supported SDK bounds. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs the existing
@traceai/fi-instrumentation-vertexaiadapter for the legacy@google-cloud/vertexaiSDK. This is not the modern@google/genaiadapter in #493, nor the Python changes in #248 / #312.setTracerProvider()setup no longer silently retains a stale tracer.gen_ai.input.messages/gen_ai.output.messagesfields, including function data, so granular FI privacy controls apply. Do not export duplicated raw bodies, media bytes/URIs or provider error messages/stacks. Telemetry failures preserve SDK success/error behavior.TextEmbeddingModelhook: the supported SDK does not export that class. Document the actual legacy SDK scope and upstream migration route instead of claiming embedding support.Reproduction and verification
Baseline: current
devat5ae2b9b4a3678af52abc01d90e4fe2fe1d4c2099. The normal setup failed to export spans. After explicitly re-enabling only to isolate further baseline defects, eight separate regressions also failed at each SDK bound: generation metadata, chat model/history, aggregate-only streams, preview tracing, manual disable, candidate/tool capture, raw-media capture and zero token counts.Final validation used synthetic Google/FI credentials and an OS sandbox denying outbound networking except localhost. Google SDK authentication/request construction and response/SSE parsing are real; provider HTTP responses are synthetic fixtures. OTLP is actually exported over HTTP to a local receiver and decoded. This is not a claim of live Google or Future AGI service testing.
pnpm run build:ordered, frozen workspace installation,release_plan.py --check(129 packages), andgit diff --checkpassed. Frozen installation retains existing unrelatedarrow2csvbin-link warnings; the command succeeds and the lockfile is unchanged.Compatibility and release notes
This is a compatibility repair for an upstream-deprecated SDK, not a new recommended SDK for applications. The README points developers toward Google's migration guide, without claiming that the separate modern traceAI adapter is published.
Content is now emitted only in standard message attributes rather than additional raw/input/output copies. The Node engine correction reflects the requirements already imposed by the existing FI core dependency; no newly imposed runtime requirement or breaking API is intended.
The customer docs draft is held until this repair is released, because the currently published adapter does not contain these fixes. No docs-main PR, registry publication, workflow dispatch or merge is part of this PR. The GitHub workflow runs the same compatibility matrix on PR changes.
E2E coverage
Not applicable to the product application's E2E map. This SDK package has committed real-SDK, packed-consumer, exact-README and loopback-OTLP tests instead.
🤖 Generated with Claude Code