Repository navigation
ci(java): keep the Spring AI consumer on the reactor version - #500
Merged
Merged
Conversation
The consumer from #473 pinned traceai.version 1.0.0 while #481 moved the reactor to 1.0.1, so its CI resolved the published 1.0.0 JAR, which lacks SpringAIObservationFilter, and the Spring AI checks fail on dev. Its release-please extra-file also pointed at java/java/... (paths are relative to the package), which release-please skipped. release_plan --check now reads versions marked x-release-please-version in poms outside the reactor and reports drift from java/pom.xml, as it does for npm VERSION constants and Python __version__. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spring AI compatibility checks (Spring AI 1.1.0, 1.1.8 and 2.0.2) fail on every dev push since #473 merged:
Cause.
java/compatibility/spring-ai/pom.xml(added in #473) pinstraceai.versionto 1.0.0. #481 then moved the reactor to 1.0.1, and the back-merge brought that to dev. The workflow installs the 1.0.1 reactor locally, but the consumer asks for 1.0.0 and gets the published JAR from Central, which predatesSpringAIObservationFilter. #473's own CI passed because dev was still at 1.0.0 then.Changes.
traceai.versionto 1.0.1. Release-please's Maven updater bumps both on future releases; I checked that with release-please 17.6.0 offline.extra-filespath. It readjava/compatibility/spring-ai/pom.xml, but release-please resolves extra-file paths relative to the package, so it looked forjava/java/...and skipped it. It is nowcompatibility/spring-ai/pom.xml.release_plan --checknow reads versions markedx-release-please-versionin poms outside the reactor. It reports drift fromjava/pom.xml, the same way it already does for npmVERSIONconstants and Python__version__. On the current dev tree it reports both problems above, so the next PR that reintroduces this drift fails its release Plan check.Checks.
test_java_consumer_pinned_to_the_reactor_version.release_plan --check,bootstrap_audit --checkand the offline release-please strategy test pass.citype, so release-please bumps nothing.🤖 Generated with Claude Code