Repository navigation
fix(firecrawl): trace v2 extraction batch agent and browser calls - #487
Merged
Merged
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Read async batch formats from the effective ScrapeOptions argument and cover the vendor SDK contracts on the supported floor and latest versions. Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Nov 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the maintained Firecrawl v2 instrumentor to cover extraction, batch scraping, agent jobs and browser sessions. These SDK operations previously ran without a Firecrawl span; the existing scrape/search/map/crawl entry points remain unchanged.
Verification
Real
firecrawl-pyclients exercise loopback API transports with non-loopback network denied. The full 259-test package suite passes on a clean wheel with Python 3.10 / Firecrawl 4.46.2 / fi-instrumentation-otel 1.1.0, and on a clean sdist with Python 3.13 / Firecrawl 4.54.0. Coverage includes lifecycle correlation, nested/concurrent calls, privacy, errors, cancellation, suppression and facade teardown.OTLP checks cover JSON and protobuf, each plain and gzip, plus the README snippet through the real default exporter. A package-specific CI matrix checks wheel/sdist installs at the SDK floor and latest supported release. No live vendor credentials are used.
Compatibility and documentation
No dependency range, public instrumentation entry point or package version changes. Job IDs and credits remain absent when the SDK does not expose them; they are not inferred from private transport internals. APIs outside the README's supported-method table are unchanged.
The existing Firecrawl docs PR is future-agi/docs#998. Its expanded coverage page must follow the package release; this PR does not publish those claims early or create a duplicate docs PR.
Related: TH-8325.
E2E coverage: not applicable (this SDK repository has no product e2e harness); real-client loopback and OTLP contract tests cover the integration boundary.
🤖 Generated with Claude Code