Repository navigation
Conversation
Restore single-await async streams, aggregate bounded thinking and tools, preserve output privacy, and restore module helpers on uninstrument. Cover real SDK 0.3.0 and 0.6.3 with offline OTLP contracts. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Normalize typed tool calls and functions in detached telemetry copies. Keep spans for SDK message mappings with optional images set to null. Add sync and async streaming privacy regressions using the real SDK. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
Keep detached-copy structure checks and require whole-value privacy placeholders on the wire. Co-Authored-By: Claude Code <noreply@anthropic.com>
Exercise the RAG example with a real offline SDK client. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retain the native Ollama Python package and repair its tracing contract. OpenAI-compatible tracing does not cover applications using
ollama.Clientorollama.AsyncClient.awaitfor streaming chat and generate calls, including positional stream arguments.Verification
d6a9966dd4d5d5fb344f7f5ab11b7483c2c2a6bc: the original 22-case regression set had 18 failures and 4 passes, independently with Ollama 0.3.0 and 0.6.3. Failures include the extra-coroutine async contract, lost thinking/tools, missing alias restoration, and unclosed spans.Ollama Python contractsCI for both SDK versions, with test execution inside a network-disabled Linux namespace.Run locally after installing the package and test tools:
Review and rollout
e2e/coverage harness. No migrations, frontend contracts, or configured Ruff gate apply to this package.OllamaInstrumentorentry point and supported SDK floor are unchanged; no version or changelog sections were edited.Privacy settings: what now holds
Ollama typed tool inputs retain adapter-side sanitization, while exported opaque aggregates follow the core whole-value
__REDACTED__contract. The tests now check both layers independently without dropping marker-absence, request integrity, or existing parameterized cases. The RAG example also defines its context before use.The RAG regression fails on the previous round-one head with undefined
context, then passes on the final head. Historical PR-base and current-dev comparisons were recorded separately; their failures were not used to waive final-head failures.Limits: validation uses Python 3.12 and the two SDK versions in the package CI matrix, synthetic data, offline SDK transports, and a VM-local provider/OTLP receiver. The 72 receiver cases per version cover typed chat inputs with input-text, input-message, and whole-input hiding across synchronous/asynchronous and streaming/non-streaming calls. Output/image/embedding behavior is covered by the package serialization suite, not an equivalent expanded HTTP receiver matrix. No real provider or production workload was contacted. Core privacy policy is unchanged.
🤖 Generated with Claude Code