Repository navigation
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the Qdrant Java package: its semantic retrieval/vector spans remain useful. Repair the blocking-only wrapper rather than retire it.
queryAsync,queryBatchAsync, andqueryGroupsAsync, with SDK timeout and read-consistency options passed through unchanged.unwrap()working.ListenableFuturethat preserves results, failure causes, cancellation acceptance/interrupt flags and caller-selected listener executors. End one semantic span before exposing completion, including cancellation and synchronous SDK failures. This also prevents blocking callers from shutting down tracing before the completion callback ends its span.Verification
exposesNonBlockingUniversalQueryfails withNoSuchMethodExceptionbefore the fix.get()and span completion. It now verifies that the returned future does not expose the outcome before the span ends. Rejected cancellation and caller-selected listener executors are also covered.-Djava.net.preferIPv4Stack=truefor sandbox-compatible sockets.Re-run for each client version:
mvn -B -ntp -f java/pom.xml -pl traceai-java-qdrant -am \ -Dqdrant.version=1.16.2 \ -Dtest=TracedQdrantClientTest,TracedQdrantWireTest \ -Dsurefire.failIfNoSpecifiedTests=false clean testScope and release
No version or changelog bump. Release-please owns publishing. No merges, tags or releases performed.
The package still does not promise coverage of every Qdrant API; operations on
unwrap()bypass this wrapper. As with the SDK itself, applications propagate context for their own future listeners.Existing Maven Central 1.0.0 installation guidance is corrected in future-agi/docs#1062; documentation for the new async surface must wait for a registry release. A
javap -publiccomparison against the published 1.0.0 JAR confirms all 10 released public constructor/method signatures remain present (18 additions).E2E coverage
Not applicable (no product e2e/ harness). The package has synthetic gRPC-to-OTLP integration coverage.
Generated with Claude Code