Repository navigation
fix(core): harden content privacy and sampling (1.2.2) - #313
Merged
Merged
Conversation
Apply content hiding before SDK sampling and processors, preserve sampler retention, cover event and link content, and restore safe suppression and exporter endpoint behavior. Co-Authored-By: Claude Code <noreply@anthropic.com>
This was referenced Oct 31, 2026
Document explicit provider shutdown for application termination, remove automatic signal-export promises, and preserve native held/in-flight export assertions with application-owned handlers and exit codes. Co-Authored-By: Claude Code <noreply@anthropic.com>
Require the redaction sentinel only when input hiding is enabled, retain parsed JSON assertions for visible inputs and output-only hiding, and keep response and top-level metadata assertions intact. Co-Authored-By: Claude Code <noreply@anthropic.com>
Keep invocation-parameter sentinel assertions strict for source and repaired core, while preserving JSON assertions for the exact published 1.1.0 compatibility wheel. Verify imported package paths so stale installed metadata cannot exempt source tests. Co-Authored-By: Claude Code <noreply@anthropic.com>
Resolve python/README.md against the README rebuilt by #304: keep dev's README and add this PR's application-owned shutdown guidance as a short "Shutdown on termination" section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nik13
added a commit
that referenced
this pull request
Oct 31, 2026
Resolve against core 1.2.2 (#313), MCP 0.1.3 (#311) and Vertex AI (#312): - version.py: keep 1.2.2 with the x-release-please-version marker. - mcp CHANGELOG: keep the real 0.1.3 fixes from #311 instead of the bootstrap placeholder for the same version. - vertexai CHANGELOG: record #312's fixes under the 0.1.11 release. - manifest: python (fi-instrumentation-otel) 1.2.1 -> 1.2.2 to match. release_plan.py --check and bootstrap_audit.py --check pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare
fi-instrumentation-otel1.2.2 with the reviewed privacy and safety repairs.provider.shutdown()during termination, remove automatic signal-export guarantees, and retain native Replicate held/in-flight span-export assertions, including application-selected exit status.Core content hiding is not default credential-field redaction for visible payloads; that remains an instrumentor responsibility.
Verification
All local test processes used a credential-scrubbed environment with outbound networking denied except localhost. External denial was positively verified.
_timeoutassertion failures reproduce on untouched dev; they remain visible and unwaived.traceAI-openai==0.1.10/ core 1.1.0 with OpenAI 3.24.0. Untouched-source negative controls still fail the five masked cases, even with a legacy wheel installed, proving source privacy assertions remain strict.git diff --checkpasses.Integration notes
No dependency on #292–#307. Excluded unrelated #304 README content, #306 registry metadata and the #303 release-please version marker. The new core README section is limited to the shutdown migration. Preserve 1.2.2 when integrating overlapping version/metadata work. No merge, tag or publication is performed here.
🤖 Generated with Claude Code