Repository navigation
fix(open-agent-spec): replace copied exporter with maintained privacy - #1064
Merged
Merged
Conversation
Delete the unnecessary tracing helper and use released register, LangChainInstrumentor and TraceConfig APIs. Preserve content privacy and scoped LangGraph support, with stronger explicit error masking and offline OTLP regressions. Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision
Delete the unnecessary copied Agent Spec tracing helper, not the valid LangGraph integration. No new package or SDK release is needed: fi-instrumentation-otel 1.2.2 and traceai-langchain 0.2.1 already provide the maintained setup.
Change
examples/frameworks/open-agent-spec/futureagi_tracing.pyand the copied exporter/filter from the guide.register(),LangChainInstrumentorand explicitTraceConfig(hide_error_details=True)in the page, executable companion and JSON-loading probe.ERRORand exception type.finally, including failures.No SDK public API, version, CHANGELOG or unrelated integration changed. The deleted file was copied example code, not an installable package entry point. PR #1026 covers general privacy documentation, not this helper; traceAI #393 addresses a separate optional Protect lifecycle issue.
Reproduction and verification
Base:
a9c15b9db3e180adcac5403cf98d7af2d5495e30.The five new maintained-setup regression cases fail against the unchanged page/example on both dependency cells. After this change, all 35 Agent Spec tests pass in each cell on Python 3.12.10:
Both use registry-installed traceai-langchain 0.2.1 and fi-instrumentation-otel 1.2.2. Tests run with an empty environment, isolated HOME and OS-level outbound denial except localhost. IPv4/IPv6 denial was separately confirmed. Only the model is synthetic; the actual Agent Spec loader, LangGraph runtime, callbacks, maintained privacy and OTLP/HTTP exporter execute. No vendor/model APIs or real credentials were used.
Coverage includes raw OTLP privacy, auth headers and resource/path, exact page snippet execution with and without content capture, failure-time flushing, sync/async runs, two independent runs, model/tool exceptions, error-privacy precedence, JSON loading and existing fixture contracts. No broader adapter or hosted-ingestion claim is made.
Re-run after installing
examples/frameworks/open-agent-spec/requirements.txt(for the floor also pin the four framework packages shown above):Documentation checks passed:
npm run test:integrations: 9 passed.npm run check:integrations.npm run audit-links: zero broken navigation/content links; 28 existing orphan-page warnings.npm run build: Astro and Pagefind completed; existing redirect-page HTML warnings.git diff --check.At final head
0bbd51d08e491445da6eee461d5cfd2deb5b2e2b, both GitHub checks pass:Self-review
No introduced correctness findings after tracing the maintained setup through OTLP, checking the full diff and whitespace-ignored diff, and reviewing error/privacy and failure-path tests. No configured Ruff gate, migrations, frontend contracts or OSS/EE boundary applies to this docs/example change.
E2E coverage
Not applicable (no e2e/ harness); the real page snippet and companion run through the offline integration tests above.
No merge, tag or package publication performed.
Generated with Claude Code