Skip to content

fix(open-agent-spec): replace copied exporter with maintained privacy - #1064

Merged
nik13 merged 2 commits into
mainfrom
fix/open-agent-spec-maintained-privacy
Nov 4, 2026
Merged

nik13 merged 2 commits into
mainfrom
fix/open-agent-spec-maintained-privacy

Conversation

@nik13

@nik13 nik13 commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Decision

Delete the unnecessary copied Agent Spec tracing helper, not the valid LangGraph integration. No new package or SDK release is needed: fi-instrumentation-otel 1.2.2 and traceai-langchain 0.2.1 already provide the maintained setup.

Change

  • Remove the 149-line examples/frameworks/open-agent-spec/futureagi_tracing.py and the copied exporter/filter from the guide.
  • Use register(), LangChainInstrumentor and explicit TraceConfig(hide_error_details=True) in the page, executable companion and JSON-loading probe.
  • Preserve input/output privacy switches, model/tool spans, token counts, project routing and one-instrumentor guidance. Error privacy is deliberately stronger: omit exception messages, stack traces and status descriptions even with content capture enabled; retain ERROR and exception type.
  • Pin the example to released packages and document those minimum versions. Flush the page's script in finally, including failures.
  • Keep the guide scoped to self-hosted Future AGI and Agent Spec 26.3.1's LangGraph agent adapter. Remove the affirmative third-party setup snippet rather than imply portable adapter/flow support. Agent Spec's separate SpanProcessor route remains linked, with a duplicate-tracing warning.

No SDK public API, version, CHANGELOG or unrelated integration changed. The deleted file was copied example code, not an installable package entry point. PR #1026 covers general privacy documentation, not this helper; traceAI #393 addresses a separate optional Protect lifecycle issue.

Reproduction and verification

Base: a9c15b9db3e180adcac5403cf98d7af2d5495e30.

The five new maintained-setup regression cases fail against the unchanged page/example on both dependency cells. After this change, all 35 Agent Spec tests pass in each cell on Python 3.12.10:

Dependency cell pyagentspec langgraph langchain-core langchain langchain-openai Result
Adapter floor 26.3.1 1.2.4 1.4.6 1.3.9 1.2.1 35 passed
Current 26.3.1 1.2.19 1.7.3 1.4.7 1.2.2 35 passed

Both use registry-installed traceai-langchain 0.2.1 and fi-instrumentation-otel 1.2.2. Tests run with an empty environment, isolated HOME and OS-level outbound denial except localhost. IPv4/IPv6 denial was separately confirmed. Only the model is synthetic; the actual Agent Spec loader, LangGraph runtime, callbacks, maintained privacy and OTLP/HTTP exporter execute. No vendor/model APIs or real credentials were used.

Coverage includes raw OTLP privacy, auth headers and resource/path, exact page snippet execution with and without content capture, failure-time flushing, sync/async runs, two independent runs, model/tool exceptions, error-privacy precedence, JSON loading and existing fixture contracts. No broader adapter or hosted-ingestion claim is made.

Re-run after installing examples/frameworks/open-agent-spec/requirements.txt (for the floor also pin the four framework packages shown above):

python -m pytest examples/frameworks/open-agent-spec/tests -q -p no:cacheprovider

Documentation checks passed:

  • npm run test:integrations: 9 passed.
  • npm run check:integrations.
  • npm run audit-links: zero broken navigation/content links; 28 existing orphan-page warnings.
  • npm run build: Astro and Pagefind completed; existing redirect-page HTML warnings.
  • Both external documentation links return HTTP 200.
  • git diff --check.
  • The built guide renders at HTTP 200 in an isolated Chrome session with external requests blocked: six code blocks, the privacy warning and setup/trace sections render correctly, no browser page errors. Top/setup/privacy screenshots inspected locally; no fabricated product screenshot added.

At final head 0bbd51d08e491445da6eee461d5cfd2deb5b2e2b, both GitHub checks pass:

Self-review

No introduced correctness findings after tracing the maintained setup through OTLP, checking the full diff and whitespace-ignored diff, and reviewing error/privacy and failure-path tests. No configured Ruff gate, migrations, frontend contracts or OSS/EE boundary applies to this docs/example change.

E2E coverage

Not applicable (no e2e/ harness); the real page snippet and companion run through the offline integration tests above.

No merge, tag or package publication performed.

Generated with Claude Code

nik13 and others added 2 commits October 31, 2026 09:52
Delete the unnecessary tracing helper and use released register, LangChainInstrumentor and TraceConfig APIs. Preserve content privacy and scoped LangGraph support, with stronger explicit error masking and offline OTLP regressions.

Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
@nik13
nik13 merged commit af81202 into main Nov 4, 2026
2 checks passed
@nik13
nik13 deleted the fix/open-agent-spec-maintained-privacy branch November 4, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant