Repository navigation
fix(tracing): use FITracer for TypeScript custom spans - #1047
Merged
Merged
Conversation
Exercise the published wrapper and actual MDX snippet at the OpenTelemetry floor and current versions with loopback-only OTLP checks. Co-Authored-By: Claude Code <noreply@anthropic.com>
Use zero-argument callbacks and Span.current() for each nested span. Complete the Java imports and link provider initialization. Add a Maven Central 1.0.1 snippet regression test and CI check covering compilation, OTLP export, span kinds, attributes, lifecycle, and parentage. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the TypeScript custom-span guide to use the already-published
FITracerwrapper rather than a raw OpenTelemetry tracer.context.with.finally. Flush on script shutdown; explain how servers reuse their provider and context manager.Keep, fix, or delete
Keep
@traceai/fi-core. The defect is in the guide, not the package. The example runs with registry version 1.1.0; no SDK release, additional integration package, package deletion, or deployment ordering is needed.No open PR changes this page. Docs #1026 covers related privacy reference pages but does not fix this example.
Verification
@traceai/fi-core1.1.0: raw spans omitsession.id/user.id, expose the synthetic input, and never export a span when the callback throws beforespan.end(). The context manager was enabled.skipLibCheckskips third-party declarations).npm run test:integrations: 9/9 passed.npm run check:integrations: passed.npm run build: passed (794 indexed pages).npm run audit-links: zero broken navigation/content links; 28 pre-existing orphan pages reported.Re-run the snippet checks with
npm ci --ignore-scripts --prefix examples/sdk/fitracer-typescriptfollowed bynpm test --prefix examples/sdk/fitracer-typescript. The dedicated workflow additionally runs in a loopback-only Linux network namespace.E2E coverage
Not applicable (no product
e2e/harness in this documentation repository). The doc example is exercised through its actual published OTLP exporter, and the documentation page was rendered locally. No vendor/model API or live Future AGI account was used.Review
Self-reviewed against internal standards. No introduced blocking findings; no public SDK API changes, version bumps, generated helper code, or unrelated page edits.
🤖 Generated with Claude Code