Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/sdk-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ jobs:
--deselect tests/test_harness_sandbox_server.py::test_public_github_branch_url_populates_job_ref
tests/test_harness_architecture.py
tests/test_harness_credentials.py
tests/test_harness_secrets.py
tests/test_harness.py
--deselect tests/test_harness.py::test_hosted_claude_session_uses_durable_resume_and_restricted_tools
--deselect tests/test_harness.py::test_a_skill_only_names_tools_its_stage_actually_has
Expand Down
16 changes: 13 additions & 3 deletions tests/test_harness_secrets.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ def test_worker_inherits_runner_topology_but_uploaded_values_cannot_replace_it()
assert child["HARNESS_RUNTIME_WEBHOOK_URL"] == "http://runner.internal:8787"


def test_worker_never_inherits_host_voice_provider_credentials():
def test_worker_inherits_only_the_runners_cartesia_voice_credential():
child = worker_environment(
{"LIVEKIT_API_KEY": "job-livekit"},
{"LIVEKIT_API_KEY": "job-livekit", "CARTESIA_API_KEY": "job-cartesia"},
host_environment={
"PATH": "/bin",
"LIVEKIT_API_KEY": "runner-livekit",
Expand All @@ -149,7 +149,17 @@ def test_worker_never_inherits_host_voice_provider_credentials():
assert child["LIVEKIT_API_KEY"] == "job-livekit"
assert "LIVEKIT_API_SECRET" not in child
assert "DEEPGRAM_API_KEY" not in child
assert "CARTESIA_API_KEY" not in child
# The one exception: the runner's Cartesia key voices the simulated caller
# (call_runner.py, `cartesia_key`), so the worker inherits it (f0b3fcea, #69), and a job's
# own value can't replace it.
assert child["CARTESIA_API_KEY"] == "runner-cartesia"

# A job that sends no LiveKit key gets none: the runner's key isn't inherited either.
without_job_keys = worker_environment(
{},
host_environment={"PATH": "/bin", "LIVEKIT_API_KEY": "runner-livekit"},
)
assert "LIVEKIT_API_KEY" not in without_job_keys


def test_worker_inherits_runner_model_roles_but_jobs_cannot_replace_them():
Expand Down
Loading