Run checkdoc and silence the Easkfile warning - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
linttarget raneask lint packageonly. A problem in a docstring could pass. The target now also runseask lint checkdoc. Thereleasetarget depends onlint, so a release runs both checks.Every Eask command printed a warning about a missing
lexical-bindingcookie in the Easkfile. The file now starts with the cookie, and the warning is gone.The cookie moves the version to another line. The release target found the version by line number, so it would have changed the wrong line. It now finds the version by shape. A test showed that one line changes and the other quoted strings stay as they are.