Repository navigation
Fix startup cancellation hangs in Node workers - #67
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling a render while its worker imports the engine could leave
worker.terminate()pending on Windows and prevent the queue from starting later jobs. Start the synchronous engine call fromsetImmediate, after module evaluation completes, while retaining the existing requirement to wait for worker exit before settling the request.Prepare package 0.9.5 with the engine still pinned to 2.5.51. Add a 64-cycle installed-package gate that sweeps startup cancellation timings, rejects expired queued work, observes actual worker exits, and compares every recovery PDF and preview with an uncancelled baseline. CI retains its lifecycle record, logs and PDF/PNG output. The repository language adjustment also excludes development tooling from Linguist statistics.
Validation:
This fix addresses startup cancellation; it does not claim to resolve the separate native-crash investigation in issue #7.