Repository navigation
Fix font-family cascade in the packaged engine - #66
Merged
Merged
Conversation
krflol
marked this pull request as ready for review
November 1, 2026 18:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fullbleed 0.9.4 for JavaScript embeds engine 2.5.51. Concrete
font-familydeclarations now replace losing custom-property values correctly. An invalid winning custom-property value inherits the parent font. The JavaScript API is unchanged.All 13 CI jobs passed: nine installed-package combinations across Windows, Linux and macOS with Node 22, 24 and 26; Chromium, Firefox and WebKit; and the native/WASI output checks. Existing component, queue, batch, pagination, paint, counter and font gates remain in place.
Thirteen saved font witnesses pass independently in Linux and Windows, with matching PDF and PNG bytes. The actual public 0.9.3 package reproduces eleven incorrect font selections and two healthy controls; 0.9.4 corrects the eleven and preserves both controls. A fresh installation of the exact release tarball also passes all thirteen witnesses, and all 50 installed payload files match the archive. The evidence archive includes retained output and its checks.
These are fixture-specific results, not a claim of complete browser CSS support. The expanded component API remains alpha.
Change review. Verified source:
5dd773f972f5b3a4231b17496eb61e96b20b001e.