Repository navigation
Fix pagination in browser starter invoices - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding rows to the HTML invoice in the plain JavaScript, React and Vue starters currently keeps a fixed A4 wrapper. A 24-row invoice reports success but draws 1,334 characters below its only page. Use flowing page margins, repeating table headings and page counters, and keep the total/payment block together. The same 24 rows now occupy three pages.
Each existing starter workflow now checks actual PDF downloads and every preview for short, long, empty, wrapped and page-boundary invoices. The READMEs explain how to extend the table and update its sample totals.
Validation: all three locked app builds passed; eight Chrome fixtures (18 pages per app) and short/long Firefox and WebKit fixtures passed. The three apps produce byte-identical PDFs and previews, and every distinct page was visually reviewed. Fullbleed remains pinned to 0.8.4 / engine 2.5.40; no package release is needed.