Repository navigation
Keep files deeper than maxdepth in a recursive LocalFileSystem.rm - #2238
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalFileSystem.rm(path, recursive=True, maxdepth=...)ignoresmaxdepthand callsshutil.rmtree, so it deletes the whole tree, including files belowmaxdepth:The base
AbstractFileSystem.rmonly expands the path down tomaxdepth, and #2233 just mademvkeep files deeper thanmaxdepthin the source for the same reason.With this change, when
maxdepthis given,LocalFileSystem.rmexpands the path with that depth, removes the files it finds, and removes a directory only once it is empty. A directory that still holds deeper files is kept. Withoutmaxdepthit still usesshutil.rmtree.Tests: added
test_rm_recursive_maxdepth_keeps_deeper_filesintest_local.py. It fails on master and passes here.test_local.pypasses, and pre-commit is clean on the changed files. Added a changelog entry.