Repository navigation
Read config files as UTF-8 - #2226
Merged
Merged
Conversation
set_conf_files opened .ini and .json files with the locale encoding, so on Windows a UTF-8 config with non-ASCII values was read as mojibake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_conf_filesreads.inifiles withConfigParser.read()and.jsonfiles with a bareopen(), so both use the locale encoding. On Windows that's cp1252/cp1254 and so on, which turns a UTF-8 config value into mojibake:Both now read the files as UTF-8 (JSON has to be UTF-8 anyway), and the config docs say so. The new test fails on master on Windows; on Linux CI it passes either way since the locale there is already UTF-8.
Tested on Windows (Python 3.12, cp1254 locale):
pytest fsspec/tests/test_config.pygoes from 1 failed to 8 passed, and the fullpytest fsspecrun fails on the same tests as master. pre-commit is clean.