Repository navigation
Conversation
Assisted-by: OpenAI GPT-6 <noreply@openai.com>
martindurant
reviewed
Oct 7, 2026
martindurant
left a comment
Member
There was a problem hiding this comment.
From the very purpose of this PR, I think it is reasonable to assume that none of the inputs to a mapping have magic characters. Have you found usage where this is untrue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FSMap keys containing glob characters are currently interpreted as patterns when reading or deleting them. For example, with both
chunk[0]andchunk0present, readingchunk[0]returns the wrong file (and can return a dictionary), and deleting it can deletechunk0. The same issue affects a root such asstore[0], includingclear().Use literal
cat_file/rm_fileoperations for these paths, preserving existing bulkcat/rmcalls for ordinary paths andrm-only backend compatibility for ordinary deletions. Literal bulk reads retain raise/omit/return error handling and duplicate-key behavior. Add regressions across memory, local, async wrapper, and simplecache, plus deletion/pop controls for anrm-only backend, and a changelog entry.For roots containing glob characters,
clear()removes all mapping keys while leaving any empty subdirectories. Bulk operations on paths containing glob characters run per file; ordinary bulk operations retain their existing implementation.Validation (Windows, Python 3.13.11):
|in local filenames and independently fail with WinError123 on unchanged tests.mwaskom/seaborn-data(these passed in the earlier run). Optional dependency/cloud tests account for the skips.AI assistance disclosure: implementation and tests prepared using OpenAI GPT-6; independent read-only review by Anthropic Claude Opus, with its compatibility finding reproduced and fixed. No human review is implied by this disclosure.