Expand Cosmos Emulator tests and harden read extension validation by Copilot · Pull Request #18 · fsprojects/FSharp.Azure.Cosmos

Copilot · 2026-05-23T18:19:38Z

This PR expands Cosmos Emulator integration coverage and incorporates review-driven fixes in both tests and read extension behavior.

Changes Made

Expanded and reorganized operation/read integration tests with scenario-based seeding using DatabaseTestApplicationFactory derivatives (SingleItemScenario, MultipleItemsScenario).
Refactored integration test infrastructure to support generic IntegrationTestBase<'DatabaseTestApplicationFactory> / OperationTestBase<'DatabaseTestApplicationFactory> patterns.
Added shared TestCategories constants and applied explicit TestCategory attributes across test classes.
Updated IsNotDeletedAsync in Cosmos.fs:
- changed deletedFieldName to non-nullable string,
- kept an explicit runtime nullArg guard,
- retained strict identifier validation for invalid field names,
- corrected requestOptions parameter naming.
Added XML <exception> documentation for methods that throw in Cosmos.fs (IsNotDeletedAsync, AddPreTriggers, AddPostTriggers).
Expanded read extension integration coverage for deleted-field-name validation and behavior, including:
- null/empty/whitespace invalid inputs,
- invalid start and invalid character cases,
- valid underscore and digit-in-body field names,
- verification that setting a valid digit-containing deleted marker changes IsNotDeletedAsync result as expected.
Formatted updated F# files with Fantomas.

Validation

dotnet build FSharp.Azure.Cosmos.slnx
dotnet test FSharp.Azure.Cosmos.slnx
dotnet test tests/Cosmos.Tests/FSharp.Azure.Cosmos.Tests.fsproj
dotnet test tests/Cosmos.Tests/FSharp.Azure.Cosmos.Tests.fsproj --filter "FullyQualifiedName~ReadExtensionsIntegrationTests"
Final automated validation checks passed (code review + security scan).

xperiandri

Fix and format with Fantomas according to your instructions

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/727cc9a9-e850-45de-b65f-4e8eb8ff33fc Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/63ac5990-d78f-452f-9f2f-85e08fdbff91 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/6f71a1f0-316c-4294-88a6-23f8995238fc Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

…h AndRead coverage

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/a905fb7f-9390-4144-84f7-22ff34a8fb8c Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

…mulator readiness

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/b2eda2fa-a0cb-4604-b8ca-51bd73075963 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

…eding Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/fb87fcd3-5c25-4e1f-ab2c-0f29ce614280 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/fb87fcd3-5c25-4e1f-ab2c-0f29ce614280 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

xperiandri · 2026-05-24T23:03:18Z

+                       $"""SELECT VALUE COUNT(1)
+                          FROM item
+                          WHERE item.id = @Id
+                          AND (NOT IS_DEFINED(item.{deletedFieldName}) OR IS_NULL(item.{deletedFieldName}))"""


@copilot так что с покрытием всех этих кейсов тестами?

xperiandri · 2026-05-24T23:04:52Z

+            (deletedFieldName : string | null)
            (id : string, [<Optional>] requiestOptions : QueryRequestOptions, [<Optional>] cancellationToken : CancellationToken)
            =
            task {
+                let deletedFieldName =
+                    match deletedFieldName with
+                    | null -> nullArg (nameof deletedFieldName)
+                    | deletedFieldName -> deletedFieldName


@copilot ты понимаешь что это идиотизм декларировать string | null а потом кидать исключение.

Suggested change

(deletedFieldName : string | null)

(id : string, [<Optional>] requiestOptions : QueryRequestOptions, [<Optional>] cancellationToken : CancellationToken)

=

task {

let deletedFieldName =

match deletedFieldName with

| null -> nullArg (nameof deletedFieldName)

| deletedFieldName -> deletedFieldName

(deletedFieldName : string)

(id : string, [<Optional>] requiestOptions : QueryRequestOptions, [<Optional>] cancellationToken : CancellationToken)

=

if deletedFieldName |> withNull |> isNull then

nullArg (nameof deletedFieldName)

task {

Исправил в 69776da (уточнение в 1a73340): сигнатура теперь deletedFieldName : string, при этом runtime guard оставлен через nullArg для null-входа.

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/7c652b6b-140a-42c5-9e86-a71d0a69c5ba Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

xperiandri

@copilot изучи все методы на классе Assert и переделай все assert'ы на подходящие overloads.
Обработай все комментарии

xperiandri · 2026-08-28T18:51:19Z

+                       $"""SELECT VALUE COUNT(1)
+                          FROM item
+                          WHERE item.id = @Id
+                          AND (NOT IS_DEFINED(item.{deletedFieldName}) OR IS_NULL(item.{deletedFieldName}))"""


But it must be true to be treated as deleted
if it is { "deleted": false } it is not deleted

xperiandri · 2026-08-28T19:19:02Z

+                let isAsciiLetter c = ('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z')
+                let isAsciiDigit c = '0' <= c && c <= '9'
+
+                let isValidDeletedFieldName =
+                    if String.IsNullOrWhiteSpace deletedFieldName then
+                        false
+                    else
+                        let firstCharacter = deletedFieldName[0]
+                        let hasValidStart = firstCharacter = '_' || isAsciiLetter firstCharacter
+                        let hasValidBody =
+                            deletedFieldName
+                            |> Seq.forall (fun c -> c = '_' || isAsciiLetter c || isAsciiDigit c)
+
+                        hasValidStart && hasValidBody


Это же правила валидации имени поля в Cosmos? Давай тогда создадим вверху файла модуль CosmosName и в нём функцию [<CompiledName "ValidateField">] validateField которая будет создержать этот код. И на эту функцию напишем тесты

xperiandri · 2026-08-28T19:20:27Z

+        )
+
+    [<TestMethod>]
+    member _.``Read builder configures id partition key and request options`` () =


Suggested change

member _.``Read builder configures id partition key and request options`` () =

member _.``Read builder configures id and partition key and request options`` () =

xperiandri · 2026-08-28T19:21:17Z

+            sessionToken "read-session"
+        }
+
+        Assert.IsTrue (operation.Id = "read-id", "Read builder should set id.")


там есть метод аля Assert.Equals для сравнения строк

xperiandri · 2026-08-28T19:21:40Z

+        }
+
+        Assert.IsTrue (operation.Id = "read-id", "Read builder should set id.")
+        Assert.IsFalse (isNull operation.RequestOptions, "Read builder should initialize request options when needed.")


разве там нет метода Assert.IsNull?

xperiandri · 2026-08-28T19:23:41Z

+
+        Assert.IsTrue (operation.Id = "read-id", "Read builder should set id.")
+        Assert.IsFalse (isNull operation.RequestOptions, "Read builder should initialize request options when needed.")
+        Assert.IsTrue (operation.RequestOptions.IfNoneMatchEtag = "etag-value", "Read builder should set eTag option.")


Assert.Equals

xperiandri · 2026-08-28T19:24:11Z

+        Assert.IsTrue (operation.Id = "read-id", "Read builder should set id.")
+        Assert.IsFalse (isNull operation.RequestOptions, "Read builder should initialize request options when needed.")
+        Assert.IsTrue (operation.RequestOptions.IfNoneMatchEtag = "etag-value", "Read builder should set eTag option.")
+        Assert.IsTrue (operation.RequestOptions.SessionToken = "read-session", "Read builder should set session token.")


Assert.Equals

xperiandri · 2026-08-28T19:24:57Z

+
+        let updateResult =
+            replaceConcurrentlyOperation.Update { id = "id"; partitionKey = "pk"; value = 2 }
+            |> Async.RunSynchronously


переделай на асинхронный тест

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/f0174b7d-c2d6-4a25-aa23-d50cac7c65f3 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Copilot AI assigned Copilot and xperiandri May 23, 2026

Copilot AI linked an issue May 23, 2026 that may be closed by this pull request

Integration tests against Cosmos Emulator #13

Open

Copilot started work on behalf of xperiandri May 23, 2026 18:19 View session

Copilot AI changed the title ~~[WIP] Add integration tests against Cosmos Emulator~~ Add Cosmos Emulator integration test foundation and scoped scenario plan May 23, 2026

Copilot finished work on behalf of xperiandri May 23, 2026 18:31

Copilot AI requested a review from xperiandri May 23, 2026 18:31

xperiandri requested changes May 23, 2026

View reviewed changes

Comment thread tests/Cosmos.Tests/IntegrationInfrastructure.fs Outdated

Comment thread tests/Cosmos.Tests/IntegrationInfrastructure.fs Outdated

Comment thread tests/Cosmos.Tests/IntegrationInfrastructure.fs Outdated

Copilot started work on behalf of xperiandri May 23, 2026 22:27 View session

Copilot finished work on behalf of xperiandri May 23, 2026 22:31

Copilot AI requested a review from xperiandri May 23, 2026 22:31

xperiandri reviewed May 24, 2026

View reviewed changes

Comment thread tests/Cosmos.Tests/IntegrationTestPlan.fs Outdated

xperiandri reviewed May 24, 2026

View reviewed changes

Comment thread tests/Cosmos.Tests/IntegrationInfrastructure.fs Outdated

Copilot started work on behalf of xperiandri May 24, 2026 00:12 View session

Copilot AI requested a review from xperiandri May 24, 2026 00:16

Copilot finished work on behalf of xperiandri May 24, 2026 00:16

Copilot started work on behalf of xperiandri May 24, 2026 00:55 View session

Copilot AI changed the title ~~Add Cosmos Emulator integration test foundation and scoped scenario plan~~ Add Cosmos Emulator integration tests for core operations May 24, 2026

Copilot finished work on behalf of xperiandri May 24, 2026 01:02

Copilot started work on behalf of xperiandri May 24, 2026 01:12 View session

xperiandri reviewed May 24, 2026

View reviewed changes

Comment thread tests/Cosmos.Tests/Tests.fs Outdated

Copilot finished work on behalf of xperiandri May 24, 2026 01:22

Copilot AI requested a review from xperiandri May 24, 2026 01:22

Copilot started work on behalf of xperiandri May 24, 2026 01:22 View session

Copilot AI changed the title ~~Add Cosmos Emulator integration tests for core operations~~ Expand Cosmos Emulator tests for operations, read extensions, and builders May 24, 2026

Copilot finished work on behalf of xperiandri May 24, 2026 01:31

Copilot started work on behalf of xperiandri May 24, 2026 14:23 View session

Copilot finished work on behalf of xperiandri May 24, 2026 14:34

xperiandri force-pushed the main branch from 26f1a41 to 4c69f13 Compare May 24, 2026 14:47

xperiandri force-pushed the copilot/add-integration-tests-cosmos-emulator-again branch from 542f3fc to d5b9617 Compare May 24, 2026 14:48

Copilot AI and others added 15 commits May 25, 2026 00:56

Remove class-scope literal from operation test infrastructure

0bf340c

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/727cc9a9-e850-45de-b65f-4e8eb8ff33fc Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Rename test methods add read extension coverage and builder tests

03795eb

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/63ac5990-d78f-452f-9f2f-85e08fdbff91 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Add Assert extensions and align test namespaces

31d54c0

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/6f71a1f0-316c-4294-88a6-23f8995238fc Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Fix Assert extension signatures and keep test helper usage

d63fbff

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/6f71a1f0-316c-4294-88a6-23f8995238fc Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

fixup! Split operation integration tests into per-operation files wit…

60e97b6

…h AndRead coverage

Delete IntegrationTestPlan file per PR feedback

e1305d3

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/a905fb7f-9390-4144-84f7-22ff34a8fb8c Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Apply suggestions from code review

5d79634

Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>

fixup! ci(cosmos): use separate common action to check Azure Cosmos E…

f62634d

…mulator readiness

Fix failing Cosmos emulator tests

cd491da

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/b2eda2fa-a0cb-4604-b8ca-51bd73075963 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Handle undefined deleted marker in IsNotDeletedAsync

d53c998

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/b2eda2fa-a0cb-4604-b8ca-51bd73075963 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Validate deleted field name in IsNotDeletedAsync query

829a053

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/b2eda2fa-a0cb-4604-b8ca-51bd73075963 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Harden IsNotDeletedAsync field-name validation

a06c43a

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/b2eda2fa-a0cb-4604-b8ca-51bd73075963 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Address review feedback for nullArg, test categories, and scenario se…

5db799c

…eding Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/fb87fcd3-5c25-4e1f-ab2c-0f29ce614280 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Apply validation feedback ordering in IntegrationTestBase

842d5ed

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/fb87fcd3-5c25-4e1f-ab2c-0f29ce614280 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Simplify async exception test delegate in read extensions tests

bde1f0d

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/fb87fcd3-5c25-4e1f-ab2c-0f29ce614280 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

xperiandri force-pushed the copilot/add-integration-tests-cosmos-emulator-again branch from 2a78e83 to bde1f0d Compare May 24, 2026 22:56

fix ReadExtensionsIntegrationTests name

7badc2f

xperiandri requested changes May 24, 2026

View reviewed changes

Copilot started work on behalf of xperiandri May 24, 2026 23:06 View session

Copilot AI and others added 4 commits May 24, 2026 23:11

Refine IsNotDeletedAsync docs and validation coverage

69776da

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/7c652b6b-140a-42c5-9e86-a71d0a69c5ba Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Address follow-up review notes for IsNotDeletedAsync

1a73340

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/7c652b6b-140a-42c5-9e86-a71d0a69c5ba Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Tidy read extensions test variable naming

b9c6eae

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/7c652b6b-140a-42c5-9e86-a71d0a69c5ba Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Expand deleted-field validation coverage in read extension tests

985d3f9

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/7c652b6b-140a-42c5-9e86-a71d0a69c5ba Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Copilot finished work on behalf of xperiandri May 24, 2026 23:15

Copilot AI requested a review from xperiandri May 24, 2026 23:15

xperiandri requested changes Aug 28, 2026

View reviewed changes

Copilot started work on behalf of xperiandri August 28, 2026 20:10 View session

Changes before error encountered

e19cf82

Agent-Logs-Url: https://github.com/fsprojects/FSharp.Azure.Cosmos/sessions/f0174b7d-c2d6-4a25-aa23-d50cac7c65f3 Co-authored-by: xperiandri <2365592+xperiandri@users.noreply.github.com>

Copilot stopped work on behalf of xperiandri due to an error August 28, 2026 20:14
You have exceeded your monthly quota (Request ID: 0440:7DC5D:29DB6E:2F354E:6A91EC1D)

Copilot AI requested a review from xperiandri August 28, 2026 20:14

	member _.``Read builder configures id partition key and request options`` () =
	member _.``Read builder configures id and partition key and request options`` () =

Uh oh!

Conversation

Copilot AI commented May 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Validation

Uh oh!

xperiandri left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xperiandri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 23, 2026 •

edited

Loading