fix: resolve hubRequestOptions being overwritten in getFrameMessage - #557
fix: resolve hubRequestOptions being overwritten in getFrameMessage#557dajiaohuang wants to merge 7 commits into
Conversation
- Remove redundant else branch that was overwriting acc[type] with the same value - Fix mutable default argument by creating requestOptions object fresh each time - Properly merge user-provided hubRequestOptions with default api_key header
Create fresh requestOptions object each time to avoid shared mutable default. Properly merge user-provided hubRequestOptions with default api_key header.
Create fresh requestOptions object each time to avoid shared mutable default. Properly merge user-provided hubRequestOptions with default api_key header.
- Fix mutable default argument by using empty object as default - Add missing api_key header when using default hub URL
When using the default hub URL, user-provided hubRequestOptions (like cache, credentials, etc.) were being completely lost. Now properly merges user options with the default api_key header.
|
@dajiaohuang is attempting to deploy a commit to the Discove Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| const requestOptions = { | ||
| ...hubRequestOptions, | ||
| headers: { | ||
| ...(hubRequestOptions.headers ?? {}), | ||
| api_key: DEFAULT_HUB_API_KEY, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
getAddressForFid unconditionally injects the default public api_key header, overwriting a caller-supplied api_key even when a custom hub URL is used, breaking auth against custom hubs.
| const requestOptions = { | ||
| ...hubRequestOptions, | ||
| headers: { | ||
| ...(hubRequestOptions.headers ?? {}), | ||
| api_key: DEFAULT_HUB_API_KEY, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
getAddressesForFid unconditionally injects the default public api_key header, overriding a caller-supplied api_key even when a custom hub URL is used, which breaks auth against custom hubs.
| ...headers, | ||
| api_key: DEFAULT_HUB_API_KEY, |
There was a problem hiding this comment.
validateFrameMessage unconditionally injects the default public Neynar api_key after spreading user headers, clobbering a caller's own api_key even when a custom hubHttpUrl is used.
|
Addressed the current review feedback in the latest commit. The user-data reducer now stores the first value for each type and replaces it only when a newer timestamp is seen, so first-seen fields are no longer lost. Validation: git diff --check passed. The local checkout has no Yarn binary/dependencies, so the package test suite could not run here. |
1 participant
Summary
修复
getFrameMessage函数中hubRequestOptions被覆盖的问题。问题
当使用默认 hub URL (
DEFAULT_HUB_API_URL) 时，用户提供的hubRequestOptions（如cache、credentials等）完全丢失，因为代码直接用一个只包含api_key的对象覆盖了整个选项。代码变更
Fix
现在正确合并用户提供的选项与默认的
api_keyheader。