Repository navigation
Doors: a shared minimum padding and gap for framed boxes #1140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rebrand-doors
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -120,10 +120,10 @@ main:lang(ar) .article-layout .article-style,main:lang(ar) .article-layout .arti | |||||
| } | ||||||
| @media(max-width:1000px){.article-layout .article-card{order:1}} | ||||||
| /* Sections that open: the spoiler and expand shortcodes. */ | ||||||
| .article-layout .article-style .spoiler{margin:0 0 12px;background:var(--surface);border-radius:var(--r-small)} | ||||||
| .article-layout .article-style .spoiler>summary{padding:10px 14px;font-weight:600;font-size:18px;line-height:1.35;color:var(--link);cursor:pointer} | ||||||
| .article-layout .article-style .spoiler{margin:0 0 var(--box-gap);background:var(--surface);border-radius:var(--r-small)} | ||||||
| .article-layout .article-style .spoiler>summary{padding:var(--box-pad-y) var(--box-pad);font-weight:600;font-size:18px;line-height:1.35;color:var(--link);cursor:pointer} | ||||||
| .article-layout .article-style .spoiler>summary:hover{color:var(--ink)} | ||||||
| .article-layout .article-style .spoiler-body{padding:2px 14px 12px;font-size:18px;line-height:1.55} | ||||||
| .article-layout .article-style .spoiler-body{padding:2px var(--box-pad) var(--box-pad);font-size:18px;line-height:1.55} | ||||||
| .article-layout .article-style .spoiler-body>:last-child{margin-bottom:0} | ||||||
| /* Disclosures hold prose, so they stay at reading width unless a PDF is open inside one. */ | ||||||
| .article-layout-wide .article-style .spoiler:not([open]),.article-layout-wide .article-style .spoiler:not(:has(.pdf-viewer)){max-width:580px} | ||||||
|
|
@@ -172,11 +172,15 @@ main:lang(ar) .article-layout .article-style,main:lang(ar) .article-layout .arti | |||||
| .sc-page .crumbs{margin-bottom:18px} | ||||||
| .sc-page #sc-container{padding:0;font-family:var(--text);max-width:none} | ||||||
| /* A team's name heads its own row, so it cannot end one row with its people starting the next. */ | ||||||
| .sc-page .sc-grid .sc-title-card{flex:0 0 100%;grid-column:1/-1;width:100%;aspect-ratio:auto;padding:10px 16px;flex-direction:row;align-items:baseline;justify-content:flex-start;gap:10px} | ||||||
| .sc-page .sc-grid .sc-title-card{flex:0 0 100%;grid-column:1/-1;width:100%;aspect-ratio:auto;padding:var(--box-pad-y) var(--box-pad);flex-direction:row;align-items:baseline;justify-content:flex-start;gap:10px} | ||||||
| .sc-page .sc-title-card :is(.sc-title-label,.sc-title-text){margin:0} | ||||||
| .sc-page .sc-title-card .sc-title-text{font-size:17px} | ||||||
| .sc-page .sc-title-card .sc-cbar{display:none} | ||||||
| .sc-team{display:contents} | ||||||
| /* On a phone the cards and team names share one grid: the box gap between them, and a team's name further | ||||||
| from the cards of the team before it than from its own. */ | ||||||
| .sc-page .sc-grid{gap:var(--box-gap)} | ||||||
| @media(max-width:760px){.sc-page .sc-grid .sc-title-card:not(:first-child){margin-top:var(--box-gap)}} | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This selector never matches the generated team bands on phones: every title card is the first child of its own Prompt for AI agents
Suggested change
|
||||||
| @media(min-width:761px){ | ||||||
| .sc-page .sc-grid{gap:28px 40px} | ||||||
| .sc-page .sc-team{display:flex;flex-wrap:wrap;align-content:flex-start;gap:1rem;width:calc(var(--sc-members)*190px + (var(--sc-members) - 1)*1rem);max-width:100%} | ||||||
|
|
@@ -213,7 +217,7 @@ main:lang(ar) .article-layout .article-style,main:lang(ar) .article-layout .arti | |||||
| .doi-link,.cite-us-text a{text-decoration:underline;text-underline-offset:3px} | ||||||
| .toc-phone{display:none} | ||||||
| @media(max-width:1000px){ | ||||||
| .toc-phone{display:block;margin:0 0 20px;padding:12px 16px;background:var(--surface);border-radius:var(--r-small)} | ||||||
| .toc-phone{display:block;margin:0 0 20px;padding:var(--box-pad-y) var(--box-pad);background:var(--surface);border-radius:var(--r-small)} | ||||||
| .toc-phone-label{margin:0 0 4px;font:700 15px/1.3 var(--text);letter-spacing:.05em;text-transform:uppercase;color:var(--soft)} | ||||||
| .toc-phone.is-short .toc-extra{display:none} | ||||||
| .toc-phone-more{margin:6px 0 0;padding:4px 0;border:0;background:none;font:600 16px/1.35 var(--text);color:var(--ink);text-decoration:underline;text-underline-offset:3px;cursor:pointer} | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,4 +28,10 @@ | |
| --display-weight:500; | ||
| --r-small:8px; | ||
| --r-large:18px; | ||
| /* Framed boxes (cards, panels, disclosures, bars with their own fill or border): the least space between | ||
| a box's edge and its text, and between two boxes side by side or one above the other. A component may | ||
| use more, never less. Small controls and chips (buttons, pills, tags) and joined groups are exempt. */ | ||
| --box-pad:16px; | ||
| --box-pad-y:14px; /* top and bottom of a one-line bar, such as a disclosure's summary */ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Prompt for AI agents |
||
| --box-gap:16px; | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -18,7 +18,7 @@ image: | |||||||||
| --- | ||||||||||
|
|
||||||||||
| <style> | ||||||||||
| .am-actions { display: grid; grid-template-columns: repeat(3, minmax(0, 1fr)); gap: 10px; margin: 18px 0 6px; max-width: 620px; } | ||||||||||
| .am-actions { display: grid; grid-template-columns: repeat(3, minmax(0, 1fr)); gap: var(--box-gap); margin: 18px 0 6px; max-width: 620px; } | ||||||||||
| .article-layout .article-style .am-playlist { display: flex; flex-direction: column; gap: 2px; padding: 12px 14px; border: 2px solid var(--am-deep) !important; border-radius: 12px; background: var(--am-tint, #eef5f3); color: var(--am-ink); text-decoration: none !important; font-size: 15px; line-height: 1.3; } | ||||||||||
|
Comment on lines
+21
to
22
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: The recording cards now use the shared gap but still retain 12px × 14px inner padding, below the 16px minimum for framed boxes. Change Prompt for AI agents
Suggested change
|
||||||||||
| .article-layout .article-style .am-playlist strong { color: var(--am-deep); font-size: 17px; } | ||||||||||
| .article-layout .article-style .am-playlist:hover { background: var(--am-tint); } | ||||||||||
|
|
@@ -232,14 +232,14 @@ image: | |||||||||
| } | ||||||||||
| .am-prog-half::after { content: ""; flex: 1; height: 1px; background: var(--am-rule); } | ||||||||||
| .am-prog-session { | ||||||||||
| margin: 0 0 10px; | ||||||||||
| padding: 8px 12px 4px; | ||||||||||
| margin: 0 0 var(--box-gap); | ||||||||||
| padding: 10px var(--box-pad) 6px; | ||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: These framed session cards still have only 10px top and 6px bottom padding, while the solo variant has just 6px at the top. Use the shared vertical token for the session padding and its solo override so the new box-spacing contract is actually met. Prompt for AI agents |
||||||||||
| border: 1px solid var(--am-rule); | ||||||||||
| border-left: 4px solid var(--am-accent); | ||||||||||
| border-radius: 8px; | ||||||||||
| background: var(--am-card); | ||||||||||
| } | ||||||||||
| .am-prog-session-solo { padding-top: 4px; } | ||||||||||
| .am-prog-session-solo { padding-top: 6px; } | ||||||||||
| .article-layout .article-style .am-prog-session h4 { | ||||||||||
| margin: 0 0 2px; | ||||||||||
| font-size: 18px; | ||||||||||
|
|
||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: This shared body padding also reaches the compact list-item Statistics spoilers, despite their explicit small-toggle styling. Add a compact
li .spoiler-bodyoverride so opening an entry does not gain the framed-box spacing.Prompt for AI agents