Repository navigation
Make three ignored settings take effect without changing results - #276
Open
antonio-leblanc wants to merge 5 commits into
Open
antonio-leblanc wants to merge 5 commits into
antonio-leblanc wants to merge 5 commits into
Conversation
setParameter strips triple quotes from a multiline value, Balbi2020.Cpa replaces the hard-coded 1150 (now its default), and FDCellsOutputs is read under its documented name.
…heck the argument One helper strips triple quotes for setParameter and startFire[geojson=]. Script lines lose a trailing CR, so CRLF multiline literals parse. The duplicate store at the end of setParameter is gone. Docs give the Balbi2020.Cpa default as 1150.
# Conflicts: # docs/source/user_guide/models.rst
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking the docs (#275):
setParameterkept the"""of a multiline value,Balbi2020.Cpawas shadowed by a local 1150, and the code readFDCellOutputsinstead ofFDCellsOutputs. Balbi2020 run ontests/runffis byte-identical before/after; ctest passes.Questions for Filippi, not changed here:
windReductionFactoris read but not applied in WindDriven;coolingis read but unused in all Balbi models; Balbi2020 uses Cpa 1150, the other Balbi 1004. Which is right?Not covered:
setParameters[...]still splits on;first, so inline tables needsetParameter.