Repository navigation
farsite: match the reference on a slope - #269
Merged
Merged
Conversation
antonio-leblanc
force-pushed
the
farsite-slope
branch
from
November 10, 2026 19:53
be69f19 to
68fda3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
second PR of #265
normalScheme=splines, where the normal has no z. slope clamped to ±0.99 so rough terrain gives no NaN; a NaN slope stays NaNtest_farsite_reference.py: 468/468 with medians, head on slope 1.000 vs reference (was 0.754 at 30°). the slope gap is now asserted--scheme splinesthe head still differs, also on flat ground: the spline normals do not point at the head. same as before this PR, only reportedrothermel and balbi get the same sinθ, up to filippi
if the core stops putting the slope in the normal z, this conversion has to go (comment in the code).
computeSpeed[]with Farsite now takes the same sinθ inputs as the nodes