Skip to content

Keep shadow conditions out of the timeline and its aggregates - #45

Merged
exe-dev-github-integration[bot] merged 1 commit into
mainfrom
fix/timeline-public-conditions
Oct 26, 2026
Merged

exe-dev-github-integration[bot] merged 1 commit into
mainfrom
fix/timeline-public-conditions

Conversation

@exe-dev-github-integration

Copy link
Copy Markdown
Contributor

Cause

Legacy probability rows were loaded from the raw download log but bypassed the pooled filter applied to current-instrument rows. The frontend rendered arbitrary condition IDs from preserved snapshots.

Fix

  • Filter timeline rows before the current/legacy split using the published experiment pooled allowlist and row publication flags.
  • Restrict generated condition cells and legend to public pooled conditions.
  • Fail closed in the chart for unknown/shadow conditions, including retained snapshots.
  • For contaminated retained snapshots, derive displayed model means and ensemble medians from public condition answers only. Leave immutable snapshot bytes and raw downloads intact.

Regression coverage

  • Current and legacy rows, ai-banned with missing flags, private news shadow, unknown future shadows and explicit unpooled/private rows.
  • Browser helper tests verify public-only dots, model means and medians; immutable source data.
  • Tooltip tests: 3 passed; experiments/runlog/build tests: 42 passed, 2 expected skips; assembly/production tests: 32 passed.
  • Local browser rendering with the production snapshot: all five public conditions, no ai-banned legend entry, no JS errors.

User requested deployment after checks; deploy frontend normally, preserving snapshot and downloads.

@exe-dev-github-integration
exe-dev-github-integration Bot merged commit 64d8429 into main Oct 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants