CHANGE @W-23480655@ require Node >=22, drop EOL Node versions - #2073
Open
WillieRuemmele wants to merge 2 commits into
Open
CHANGE @W-23480655@ require Node >=22, drop EOL Node versions#2073WillieRuemmele wants to merge 2 commits into
WillieRuemmele wants to merge 2 commits into
Conversation
aruntyagiTutu
left a comment
Contributor
There was a problem hiding this comment.
Reviewed against the Code Analyzer PR Review guidelines.
Summary: Bumps engines.node to >=22.0.0 and raises @salesforce/core/@salesforce/sf-plugins-core/@salesforce/ts-types to their next major versions, dropping Node 18/20 support. Explicitly tagged as a breaking change with a work item, and CI (build, unit tests, smoke tests on macOS/Ubuntu/Windows, lint) is green.
Two non-blocking findings:
package-lock.jsonisn't updated in this PR. The lockfile still pins@salesforce/core@8.23.4,@salesforce/sf-plugins-core@12.2.28,@salesforce/ts-types@2.0.12, andengines.node: >=20.0.0at the root — all now out of sync with the new ranges inpackage.json. CI passes because the workflows usenpm install(notnpm ci), which silently regenerates the lock in-memory, but the committed lockfile no longer reflects reproducible install state. Per the guide's dependency-management rule, the lockfile should be regenerated and committed alongside thepackage.jsonbump.- Whitespace noise mixed into the functional change. The diff reformats the entire file from tab to 2-space indentation (97 additions / 97 deletions for what's functionally a ~4-line change:
engines.node+ 3 dependency version bumps). Per the PR hygiene guidance, formatting-only changes should be separated from logic/version changes so the actual diff is reviewable.
Neither is blocking given CI is green and the intent/scope is clear, but worth cleaning up before merge.
WillieRuemmele
force-pushed
the
wr/requireNode22
branch
from
July 30, 2026 19:58
d0b23c4 to
64ba41f
Compare
Member
Author
|
Addressed both review findings:
Also resolved merge conflict with the 5.15.0 release that landed on main. |
WillieRuemmele
force-pushed
the
wr/requireNode22
branch
from
July 30, 2026 20:06
9521620 to
eb547d6
Compare
iowillhoit
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engines.nodeto>=22.0.0@salesforce/*dependencies to their new major versions@W-23480655@
BREAKING CHANGE: engines.node raised to >=22.0.0, dropping support for Node 18 and 20
Test plan
yarn buildverified locally (or pre-existing failure on main)yarn testverified locally (or pre-existing failure on main)