Repository navigation
feat(ads): pixels, conversions API and custom conversions - #38
Merged
Merged
Conversation
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ads().sendPixelConversions(params, idempotencyKey): the idempotent Conversions API send atPOST /v1/ads/conversions/events, key sent as theIdempotency-Keyheader (required, blank throws).ads().listConversionBatches(workspaceId, connectionId, limit)readsGET /v1/ads/conversions/events.ads().uploadConversionsnow returnsConversionUploadResult(id,accepted,eventCount,replayed) instead of a bare count, and has an overload taking an optional idempotency key. Existing callers reading the count switch to.accepted().pixels,createPixel,pixel,updatePixel,sharePixel,pixelStats,eventMatchQualitywithAdPixel,AdPixelDetail,AdPixelStats,EventMatchQualityrecords.customConversions,createCustomConversion,customConversion,updateCustomConversion,deleteCustomConversionwithCustomConversion/CustomConversionRuleandCreateCustomConversionParams/UpdateCustomConversionParams.ApiClient.requestgains an overload with extra headers (internal), which is how the idempotency header is sent.Tests
mvn -B verify: BUILD SUCCESS, 177 tests, 0 failures, warning-free. NewAdsTrackingTestcovers the header on the idempotent send (and its absence on the plain upload), the batch list filters, a pixel read, match quality and a custom conversion create plus delete-with-body.Owed
fopost-springdoes not referenceuploadConversions, so no lockstep PR was needed; its dependency bump happens at release.