Skip to content

Add Scala batch report as code review target - #48

Draft
krrrr38 wants to merge 1 commit into
mainfrom
feat/scala-batch-review-endpoint
Draft

krrrr38 wants to merge 1 commit into
mainfrom
feat/scala-batch-review-endpoint

Conversation

@krrrr38

@krrrr38 krrrr38 commented Sep 25, 2026

Copy link
Copy Markdown
Member

概要

Scala の面接用 patch に、銘柄別の対象ユーザー保有額を返すバッチ用 endpoint を追加します。endpoint は口座一覧を取得し、Map[StockSymbol, List[UserId]] を受け取る StockHolderJoin.join を呼び出します。

join は要改善版の実装として、ユーザー ID ごとに口座一覧を線形探索し、見つからない口座や保有銘柄を黙って飛ばします。コードレビュー課題の案内は口頭で行うため、README や課題文は変更していません。

確認

  • ./scripts/verify-interview-patch.sh scala
  • testOnly folio.codinginterview.BatchAssetScenario(成功)
  • git diff --check

Scala 版の構成を確認するための Draft PR です。他言語への展開はこの PR を見てから判断します。

Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant