Conversation
Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Scala の面接用 patch に、銘柄別の対象ユーザー保有額を返すバッチ用 endpoint を追加します。endpoint は口座一覧を取得し、
Map[StockSymbol, List[UserId]]を受け取るStockHolderJoin.joinを呼び出します。join は要改善版の実装として、ユーザー ID ごとに口座一覧を線形探索し、見つからない口座や保有銘柄を黙って飛ばします。コードレビュー課題の案内は口頭で行うため、README や課題文は変更していません。
確認
./scripts/verify-interview-patch.sh scalatestOnly folio.codinginterview.BatchAssetScenario(成功)git diff --checkScala 版の構成を確認するための Draft PR です。他言語への展開はこの PR を見てから判断します。