[MODEXPS-315] Export Configuration create/update domain events - #383
Open
Saba-Zedginidze-EPAM wants to merge 2 commits into
Open
[MODEXPS-315] Export Configuration create/update domain events#383Saba-Zedginidze-EPAM wants to merge 2 commits into
Saba-Zedginidze-EPAM wants to merge 2 commits into
Conversation
|
Please fix the Sonar issues. |
|
SerhiiNosko
reviewed
Aug 4, 2026
| public enum Topic { | ||
| JOB_COMMAND("data-export.job.command"); | ||
| JOB_COMMAND("data-export.job.command"), | ||
| CONFIG("data-export-spring.config"); |
Contributor
There was a problem hiding this comment.
better to use the same pattern and use data-export.config
SerhiiNosko
reviewed
Aug 4, 2026
| ## 2026-07-28 v3.7.0 | ||
|
|
||
| ### Stories | ||
| * Publish Kafka domain events (CREATE/UPDATE) for Export Configuration changes on `folio.ALL.data-export-spring.config` with structural credential redaction |
Contributor
There was a problem hiding this comment.
the same rename of topic need to be done here as well
SerhiiNosko
reviewed
Aug 4, 2026
| * @param tenant the tenant id | ||
| * @return the fully-qualified tenant topic name | ||
| */ | ||
| public String getTenantTopicName(Topic topic, String tenant) { |
Contributor
There was a problem hiding this comment.
do we need this method at all or can just make private String getTenantTopicName(String topicName, String tenantId) as public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
[MODEXPS-315] Export Configuration create/update domain events
Approach
Pre-Merge Checklist:
Before merging this PR, please go through the following list and take appropriate actions.