fix(am): correct the amharic dataset - #43
Conversation
This commit apply a correction to the amharic dataset. As additional changes, it split the amharic dictionary in chunks.
📝 WalkthroughWalkthroughAmharic data is refreshed through configuration and transliteration mapping changes, a normalized name translation schema, and new c, j, p, r, v, x, and z dictionary datasets. ChangesAmharic data refresh
Estimated code review effort: 4 (Complex) | ~60 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@am/code.toml`:
- Line 282: Update the "yua" entry in the mapping table to use the intended
Ethiopic glyph instead of the current Cuneiform character, while preserving its
existing yuA, yUa, and yUA aliases.
In `@am/dictionary/h.toml`:
- Line 5549: Normalize the three dictionary entries “hnn”, “hzn”, and “Hzn” to
the file’s standard object schema with `value` and `alias` fields, preserving
their current Amharic values and using appropriate aliases consistent with
neighboring entries. Do not leave any of these keys as bare strings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5a41995a-a8f9-4390-8700-1b5fa415bc76
📒 Files selected for processing (26)
am/am.tomlam/code.tomlam/dictionary.tomlam/dictionary/a.tomlam/dictionary/b.tomlam/dictionary/c.tomlam/dictionary/d.tomlam/dictionary/f.tomlam/dictionary/g.tomlam/dictionary/h.tomlam/dictionary/j.tomlam/dictionary/k.tomlam/dictionary/l.tomlam/dictionary/m.tomlam/dictionary/n.tomlam/dictionary/p.tomlam/dictionary/q.tomlam/dictionary/r.tomlam/dictionary/s.tomlam/dictionary/t.tomlam/dictionary/v.tomlam/dictionary/w.tomlam/dictionary/x.tomlam/dictionary/y.tomlam/dictionary/z.tomlam/names.toml
| "yie" = { value = "ዬ", alias = ["yiE", "yIe", "yIE", "Yie", "YiE", "YIe", "YIE"] } | ||
| "yo" = { value = "ዮ", alias = ["yO", "Yo", "YO"] } | ||
| "yu" = { value = "ዩ", alias = ["yU", "Yu", "YU"] } | ||
| "yua" = { value = "𒅀", alias = ["yuA", "yUa", "yUA"] } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Confirm the Unicode codepoint/block of the value assigned to "yua"
python3 - <<'PY'
ch = "𒅀"
cp = ord(ch)
print(f"Codepoint: U+{cp:04X}")
print("In Ethiopic block (U+1200-U+137F)?", 0x1200 <= cp <= 0x137F)
print("In Cuneiform block (U+12000-U+123FF)?", 0x12000 <= cp <= 0x123FF)
PYRepository: fodydev/afrim-data
Length of output: 259
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the relevant section of am/code.toml with line numbers
sed -n '260,292p' am/code.toml | cat -n
# Find nearby "*ua" entries and any other non-Ethiopic-looking values in this file
python3 - <<'PY'
from pathlib import Path
import re
text = Path("am/code.toml").read_text(encoding="utf-8")
for i, line in enumerate(text.splitlines(), 1):
if re.search(r'ua"\s*=\s*\{', line) or re.search(r'value\s*=\s*".*"', line):
if 'ua' in line:
print(f"{i}: {line}")
PYRepository: fodydev/afrim-data
Length of output: 4125
Fix the yua mapping
am/code.toml:282 maps "yua" to 𒅀 (U+12140, Cuneiform), but this table should stay within Ethiopic. Replace it with the intended Ethiopic glyph for the yua/yuA/yUa/yUA entry.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@am/code.toml` at line 282, Update the "yua" entry in the mapping table to use
the intended Ethiopic glyph instead of the current Cuneiform character, while
preserving its existing yuA, yUa, and yUA aliases.
Related issues
Change
Additional changes
Summary by CodeRabbit
New Features
yua.Updates