Skip to content

fix(am): correct the amharic dataset - #43

Merged
pythonbrad merged 2 commits into
masterfrom
patch_am
Jul 24, 2026
Merged

fix(am): correct the amharic dataset#43
pythonbrad merged 2 commits into
masterfrom
patch_am

Conversation

@pythonbrad

@pythonbrad pythonbrad commented Jul 24, 2026

Copy link
Copy Markdown
Member

Related issues

Change

  • apply a correction to the Amharic dataset.

Additional changes

  • split the dictionary dataset in chunks by first code letter

Summary by CodeRabbit

  • New Features

    • Added extensive Amharic translation dictionaries for additional letter groups, expanding transliteration coverage.
    • Added a new transliteration mapping for yua.
    • Expanded name aliases and standardized name translation values.
  • Updates

    • Updated Amharic data metadata to the latest version.
    • Retained Ge’ez punctuation support while removing the broader Ge’ez code include.

@pythonbrad pythonbrad self-assigned this Jul 24, 2026
This commit apply a correction to the amharic dataset.

As additional changes, it split the amharic dictionary in chunks.
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Amharic data is refreshed through configuration and transliteration mapping changes, a normalized name translation schema, and new c, j, p, r, v, x, and z dictionary datasets.

Changes

Amharic data refresh

Layer / File(s) Summary
Configuration and code mappings
am/am.toml, am/code.toml
Updates configuration versions, removes the Geez code include, reorganizes letter mappings, and adds the yua mapping.
Name translation schema
am/names.toml
Replaces values arrays with value strings and expands aliases for name translations.
Translation dictionary expansion
am/dictionary/*.toml
Adds translation mappings for the c, j, p, r, v, x, and z key ranges.

Estimated code review effort: 4 (Complex) | ~60 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing and correcting the Amharic dataset.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch patch_am

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@am/code.toml`:
- Line 282: Update the "yua" entry in the mapping table to use the intended
Ethiopic glyph instead of the current Cuneiform character, while preserving its
existing yuA, yUa, and yUA aliases.

In `@am/dictionary/h.toml`:
- Line 5549: Normalize the three dictionary entries “hnn”, “hzn”, and “Hzn” to
the file’s standard object schema with `value` and `alias` fields, preserving
their current Amharic values and using appropriate aliases consistent with
neighboring entries. Do not leave any of these keys as bare strings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a41995a-a8f9-4390-8700-1b5fa415bc76

📥 Commits

Reviewing files that changed from the base of the PR and between 42155a2 and ada80db.

📒 Files selected for processing (26)
  • am/am.toml
  • am/code.toml
  • am/dictionary.toml
  • am/dictionary/a.toml
  • am/dictionary/b.toml
  • am/dictionary/c.toml
  • am/dictionary/d.toml
  • am/dictionary/f.toml
  • am/dictionary/g.toml
  • am/dictionary/h.toml
  • am/dictionary/j.toml
  • am/dictionary/k.toml
  • am/dictionary/l.toml
  • am/dictionary/m.toml
  • am/dictionary/n.toml
  • am/dictionary/p.toml
  • am/dictionary/q.toml
  • am/dictionary/r.toml
  • am/dictionary/s.toml
  • am/dictionary/t.toml
  • am/dictionary/v.toml
  • am/dictionary/w.toml
  • am/dictionary/x.toml
  • am/dictionary/y.toml
  • am/dictionary/z.toml
  • am/names.toml

Comment thread am/code.toml
"yie" = { value = "ዬ", alias = ["yiE", "yIe", "yIE", "Yie", "YiE", "YIe", "YIE"] }
"yo" = { value = "ዮ", alias = ["yO", "Yo", "YO"] }
"yu" = { value = "ዩ", alias = ["yU", "Yu", "YU"] }
"yua" = { value = "𒅀", alias = ["yuA", "yUa", "yUA"] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Confirm the Unicode codepoint/block of the value assigned to "yua"
python3 - <<'PY'
ch = "𒅀"
cp = ord(ch)
print(f"Codepoint: U+{cp:04X}")
print("In Ethiopic block (U+1200-U+137F)?", 0x1200 <= cp <= 0x137F)
print("In Cuneiform block (U+12000-U+123FF)?", 0x12000 <= cp <= 0x123FF)
PY

Repository: fodydev/afrim-data

Length of output: 259


🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the relevant section of am/code.toml with line numbers
sed -n '260,292p' am/code.toml | cat -n

# Find nearby "*ua" entries and any other non-Ethiopic-looking values in this file
python3 - <<'PY'
from pathlib import Path
import re

text = Path("am/code.toml").read_text(encoding="utf-8")
for i, line in enumerate(text.splitlines(), 1):
    if re.search(r'ua"\s*=\s*\{', line) or re.search(r'value\s*=\s*".*"', line):
        if 'ua' in line:
            print(f"{i}: {line}")
PY

Repository: fodydev/afrim-data

Length of output: 4125


Fix the yua mapping
am/code.toml:282 maps "yua" to 𒅀 (U+12140, Cuneiform), but this table should stay within Ethiopic. Replace it with the intended Ethiopic glyph for the yua/yuA/yUa/yUA entry.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@am/code.toml` at line 282, Update the "yua" entry in the mapping table to use
the intended Ethiopic glyph instead of the current Cuneiform character, while
preserving its existing yuA, yUa, and yUA aliases.

Comment thread am/dictionary/h.toml
@pythonbrad
pythonbrad merged commit 3e5ec7b into master Jul 24, 2026
2 checks passed
@pythonbrad
pythonbrad deleted the patch_am branch July 24, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant