Skip to content

Fix: sponsor order partial cancel - #1052

Merged
smarcet merged 4 commits into
masterfrom
fix/sponsor-order-partial-cancel
Aug 26, 2026
Merged

Fix: sponsor order partial cancel#1052
smarcet merged 4 commits into
masterfrom
fix/sponsor-order-partial-cancel

Conversation

@santipalenque

@santipalenque santipalenque commented Aug 25, 2026

Copy link
Copy Markdown

https://app.clickup.com/t/9014802374/86bbgcjat
https://app.clickup.com/t/9014802374/86bbgcjy6

Summary by CodeRabbit

  • New Features

    • Order details now display line-item cancellation information.
    • Cancellations include the selected quantity and reason for improved processing.
  • Bug Fixes

    • Fixed cancellation requests so item quantity and reason are submitted correctly.
    • Improved handling when cancellation requests are unsuccessful.
  • Chores

    • Updated the application foundation for improved compatibility and stability.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f2240b86-6ee3-4d14-a5cd-0b42e258c93b

📥 Commits

Reviewing files that changed from the base of the PR and between 1d5cbb4 and 7842b15.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • package.json

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

Sponsor order details now load line-item cancellations. Cancellation requests now include quantity and reason. Rejected cancellation requests are no longer logged. The openstack-uicore-foundation dependency is updated to 5.0.53-beta.2.

Changes

Sponsor cancellation handling

Layer / File(s) Summary
Cancellation payload and dependency update
package.json, src/actions/sponsor-purchases-actions.js, src/pages/sponsors/.../sponsor-order-details.js
Order expansion requests cancellation data. The cancellation handler forwards quantity and reason. The action sends both values in the cancellation request body and retains loading cleanup without logging rejected requests. The foundation dependency is updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7842b

This localized sponsor-order cancellation change has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review.

Suggested reviewers: smarcet

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing partial cancellation for sponsor orders.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sponsor-order-partial-cancel

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Parsing error: Missing semicolon. (2:8)


Comment @coderabbitai help to get the list of available commands.

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit 43329d5 into master Aug 26, 2026
1 of 4 checks passed
@santipalenque
santipalenque deleted the fix/sponsor-order-partial-cancel branch August 26, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants