fix: add missing file remove calls from inventory popup

src/actions/__tests__/form-template-item-actions.test.js

@@ -0,0 +1,42 @@
+/**
+ * @jest-environment jsdom
+ */
+import configureStore from "redux-mock-store";
+import thunk from "redux-thunk";
+import flushPromises from "flush-promises";
+import { getRequest } from "openstack-uicore-foundation/lib/utils/actions";
+import { getFormTemplateItem } from "../form-template-item-actions";
+import * as methods from "../../utils/methods";
+
+jest.mock("openstack-uicore-foundation/lib/utils/actions", () => ({
+  __esModule: true,
+  ...jest.requireActual("openstack-uicore-foundation/lib/utils/actions"),
+  getRequest: jest.fn()
+}));
+
+describe("getFormTemplateItem", () => {
+  const middlewares = [thunk];
+  const mockStore = configureStore(middlewares);
+
+  beforeEach(() => {
+    jest.spyOn(methods, "getAccessTokenSafely").mockReturnValue("TOKEN");
+  });
+
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+
+  it("still dispatches STOP_LOADING when the request fails", async () => {
+    getRequest.mockImplementation(
+      () => () => () => Promise.reject(new Error("API error"))
+    );
+
+    const store = mockStore({});
+
+    await store.dispatch(getFormTemplateItem(123, 1)).catch(() => {});
+    await flushPromises();
+
+    const actionTypes = store.getActions().map((a) => a.type);
+    expect(actionTypes).toContain("STOP_LOADING");
+  });
+});

src/actions/__tests__/inventory-item-actions.test.js

@@ -0,0 +1,42 @@
+/**
+ * @jest-environment jsdom
+ */
+import configureStore from "redux-mock-store";
+import thunk from "redux-thunk";
+import flushPromises from "flush-promises";
+import { getRequest } from "openstack-uicore-foundation/lib/utils/actions";
+import { getInventoryItem } from "../inventory-item-actions";
+import * as methods from "../../utils/methods";
+
+jest.mock("openstack-uicore-foundation/lib/utils/actions", () => ({
+  __esModule: true,
+  ...jest.requireActual("openstack-uicore-foundation/lib/utils/actions"),
+  getRequest: jest.fn()
+}));
+
+describe("getInventoryItem", () => {
+  const middlewares = [thunk];
+  const mockStore = configureStore(middlewares);
+
+  beforeEach(() => {
+    jest.spyOn(methods, "getAccessTokenSafely").mockReturnValue("TOKEN");
+  });
+
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+
+  it("still dispatches STOP_LOADING when the request fails", async () => {
+    getRequest.mockImplementation(
+      () => () => () => Promise.reject(new Error("API error"))
+    );
+
+    const store = mockStore({});
+
+    await store.dispatch(getInventoryItem(1)).catch(() => {});
+    await flushPromises();
+
+    const actionTypes = store.getActions().map((a) => a.type);
+    expect(actionTypes).toContain("STOP_LOADING");
+  });
+});

src/actions/__tests__/inventory-shared-actions.test.js

@@ -0,0 +1,43 @@
+import { deleteRequest } from "openstack-uicore-foundation/lib/utils/actions";
+import { deleteFile } from "../inventory-shared-actions";
+import * as methods from "../../utils/methods";
+
+jest.mock("openstack-uicore-foundation/lib/utils/actions", () => ({
+  __esModule: true,
+  ...jest.requireActual("openstack-uicore-foundation/lib/utils/actions"),
+  deleteRequest: jest.fn()
+}));
+
+describe("deleteFile", () => {
+  const dispatch = jest.fn();
+  const settings = {
+    url: "http://test-api/images",
+    deletedActionName: "SOME_FILE_DELETED"
+  };
+
+  beforeEach(() => {
+    jest.spyOn(methods, "getAccessTokenSafely").mockResolvedValue("TOKEN");
+  });
+
+  afterEach(() => {
+    jest.restoreAllMocks();
+  });
+
+  it("resolves true when the delete request succeeds", async () => {
+    deleteRequest.mockImplementation(() => () => () => Promise.resolve());
+
+    const result = await deleteFile(10, settings)(dispatch);
+
+    expect(result).toBe(true);
+  });
+
+  it("resolves false (without rejecting) when the delete request fails", async () => {
+    deleteRequest.mockImplementation(
+      () => () => () => Promise.reject(new Error("boom"))
+    );
+
+    const result = await deleteFile(10, settings)(dispatch);
+
+    expect(result).toBe(false);
+  });
+});