Repository navigation
docs(skills): stamp the starter reference for magic_starter 0.0.59 and document the nav badge - #255
Conversation
…d document the nav badge magic_starter 0.0.59 (fluttersdk/magic_starter#222) adds a live count badge to MagicStarterNavItem. The page now documents badgeCount, badgeLabelKey, MagicStarterNavigationTheme.badgeClassName and MagicStarterNavBadge, and names the 0.0.59 stamp that magic_starter's skill_reference_stamp_test reads from this branch. The Wind floor quoted in the opening paragraph follows the pubspec, which moves from ^1.9.1 to ^1.10.0 in that release.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Docs-only change to one file; mostly solid, but one version claim in the new text contradicts what the file itself said a commit ago. Major
Minor
TestsDocumentation-only change (one markdown file); no test coverage applies. The nav-badge section, theme table, and widget table additions read consistently with the rest of the file (defaults like CIAll green on |
The page quoted fluttersdk_wind ^1.9.0 while magic_starter's pubspec has carried ^1.9.1 since 0.0.49. State the pubspec's move to ^1.10.0 and that the page was one step behind it, so the sentence cannot be read as a claim about the old quote.
|
Both findings checked against the source, one fixed and one handled in the description. Head is now Major: the Wind floor claim (
|
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Both prior findings are resolved; this looks good to merge. Re-reviewed the diff between The Wind-floor sentence now reads: "0.0.59 moves only the Wind floor, in the pubspec from The wording-change finding (minor) was addressed by updating the PR description to call it out as its own bullet, which is sufficient. No new findings on this incremental change — it's a one-line prose fix, no code or badge-doc content touched. TestsDocumentation-only change; no test coverage applies, as before. CIAll green on |
magic_starter 0.0.59 (fluttersdk/magic_starter#222, merged as 4f48304) adds a live count badge to
MagicStarterNavItem. This page now documents it and names the new stamp: magic_starter'stest/skill_reference_stamp_test.dartreads this file from magic's default branch and fails the 0.0.59 release PR until it says 0.0.59. No magic release is needed for that; the registry copy moves with magic's next release.Merge order: this PR first, then the magic_starter 0.0.59 release PR (its CI reads this file).
What changed
All in
skills/magic-framework/references/plugin-starter.md:<!-- magic_starter v0.0.59 | Updated: 2026-10-28 -->.MagicStarterNavItemfields gainbadgeCount(ValueListenable<int?>) andbadgeLabelKey, with a new "A count on a destination (0.0.59+)" section: the shell listens to the notifier, hidden fornullor not above zero,99+above 99, where it is drawn (labelled row, compact rail and bottom bar corner), the screen reader sentence read throughtransChoicewith the real count, thenav.badge_countinstall stub key, and that an item holding a notifier is notconst.MagicStarterNavigationTheme.badgeClassNamein the nav theme table and in theuseNavigationThemerow.MagicStarterNavBadgein the starter widgets table.plugin-deeplink.md.^1.10.0. The page had quoted^1.9.0while the pubspec has carried^1.9.1since 0.0.49; the sentence now says so. Only the Wind floor moves in 0.0.59.SKILL.mdis not touched: its version moves at magic's release, as in #250 and #254.Gates
dart format --output=none --set-exit-if-changed .: 0 changed of 482 files.flutter analyze: no issues.flutter test: 2361 passed, 1 skipped.