[camera_avfoundation] Move camera_avfoundation to Darwin by Mairramer · Pull Request #11847 · flutter/packages

Mairramer · 2026-06-05T16:32:01Z

This PR moves the camera_avfoundation plugin implementation to Darwin, aiming to consolidate the shared AVFoundation codebase for both iOS and macOS platforms.

Part of flutter/flutter#41708

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

…tep1-darwin-rename # Conflicts: # packages/camera/camera_avfoundation/pigeons/messages.dart

gemini-code-assist

Code Review

This pull request moves the camera_avfoundation package source files to a shared Darwin directory. It updates the Pigeon Swift output path to the new darwin directory, adds sharedDarwinSource: true to the iOS plugin configuration in pubspec.yaml, and documents the change in the changelog. There are no review comments, and I have no feedback to provide.

Mairramer · 2026-06-08T13:44:48Z

Maybe we should move the tests as well?

stuartmorgan-g

Maybe we should move the tests as well?

Yes, native unit tests that would be shared should move to darwin/Tests/, and the Xcode project updated to reference the files there, as with other plugins in the repo that use shared source.

…ests` to `darwin/Tests`

Mairramer · 2026-06-09T16:57:43Z

Maybe we should move the tests as well?

Yes, native unit tests that would be shared should move to darwin/Tests/, and the Xcode project updated to reference the files there, as with other plugins in the repo that use shared source.

Done.

stuartmorgan-g

LGTM

stuartmorgan-g · 2026-06-22T17:30:06Z

Version/CHANGELOG override: The only failure mode for clients here should be a complete failure to build if it were incorrect, which CI would catch, so we can skip releasing this.

okorohelijah · 2026-07-16T21:55:25Z

from triage: is this still on your radar @LouiseHsu

bparrishMines

LGTM

This PR moves the `camera_avfoundation` plugin implementation to Darwin, aiming to consolidate the shared AVFoundation codebase for both iOS and macOS platforms. Part of flutter/flutter#41708 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…er#189983) flutter/packages@8260a1e...6969329 2026-07-24 ionutzubascu@yahoo.com [packages] Migrate all iOS example apps in flutter/packages to UIScene (flutter/packages#12182) 2026-07-23 absarhshah@gmail.com [in_app_purchase] Fixes StoreKit 2 date format does not match in_app_… (flutter/packages#11717) 2026-07-23 269567208+reidbaker-agent@users.noreply.github.com [packages] Add changelog style references to AGENTS.md (flutter/packages#12277) 2026-07-23 ntosarno11@gmail.com [file_selector_android] Surface file-copy failures to Dart instead of crashing (flutter/packages#12107) 2026-07-23 puneetkukreja98@gmail.com [google_maps_flutter] Add support for mapType, fullscreen, and Street View controls on web (flutter/packages#11955) 2026-07-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from ee80f08 to 84fc5cb (5 revisions) (flutter/packages#12273) 2026-07-22 50643541+Mairramer@users.noreply.github.com [camera_avfoundation] Move camera_avfoundation to Darwin (flutter/packages#11847) 2026-07-22 engine-flutter-autoroll@skia.org Roll Flutter from 1ac2e82 to 2a2a79d (22 revisions) (flutter/packages#12272) 2026-07-22 puneetkukreja98@gmail.com [google_maps_flutter_web]: Adds support for mapTypeControlEnabled, fullscreenControlEnabled, and streetViewControlEnabled. (flutter/packages#12254) 2026-07-21 jmccandless@google.com [material_ui] Prerelease setup (flutter/packages#12258) 2026-07-21 kienhantrung@gmail.com [go_router_builder] Allow users to specify onExit as optional (flutter/packages#11151) 2026-07-21 fluttergithubbot@gmail.com Sync release-cupertino_ui-0.0.2 to main (flutter/packages#12265) 2026-07-21 tarrinneal@gmail.com [pigeon] add support for top level consts (flutter/packages#12032) 2026-07-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.12.4 to 1.13.0 in /packages/image_picker/image_picker_android/android (flutter/packages#11253) 2026-07-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump cameraxVersion from 1.6.0 to 1.6.1 in /packages/camera/camera_android_camerax/android (flutter/packages#11862) 2026-07-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.guava:guava from 33.5.0-android to 33.6.0-android in /packages/espresso/android (flutter/packages#11864) 2026-07-21 stuartmorgan@google.com [tool] Rename batch change override label (flutter/packages#12263) 2026-07-21 jmccandless@google.com [cupertino_ui] Bump minor to get to 0.0.2, not patch (flutter/packages#12260) 2026-07-21 stuartmorgan@google.com [tool] Support pre-1.0 versions in batch releases (flutter/packages#12257) 2026-07-21 jmccandless@google.com [material_ui] Remove manual version changes (flutter/packages#12253) 2026-07-21 engine-flutter-autoroll@skia.org Roll Flutter from cab057d to 1ac2e82 (23 revisions) (flutter/packages#12256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Mairramer added 3 commits May 31, 2026 17:01

refactor(camera_avfoundation): move ios to darwin

8b54751

Merge remote-tracking branch 'origin/main' into camera-avfoundation-s…

ed28734

…tep1-darwin-rename # Conflicts: # packages/camera/camera_avfoundation/pigeons/messages.dart

chore: document migration of camera_avfoundation to Darwin in CHANGELOG

08d05b4

github-actions Bot added p: camera platform-ios platform-macos labels Jun 5, 2026

Mairramer marked this pull request as ready for review June 5, 2026 16:41

gemini-code-assist Bot reviewed Jun 5, 2026

View reviewed changes

stuartmorgan-g requested changes Jun 9, 2026

View reviewed changes

Comment thread packages/camera/camera_avfoundation/CHANGELOG.md Outdated

stuartmorgan-g added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jun 9, 2026

Mairramer added 2 commits June 9, 2026 13:56

Moved all native Swift tests and mock files from `example/ios/RunnerT…

7b68f98

…ests` to `darwin/Tests`

remove irrelevant changelog message

6d88a25

stuartmorgan-g reviewed Jun 9, 2026

View reviewed changes

Comment thread packages/camera/camera_avfoundation/example/ios/RunnerTests/.gitkeep Outdated

remove unused folder

9e53fc6

stuartmorgan-g added CICD Run CI/CD override: no versioning needed Override the check requiring version bumps for most changes labels Jun 17, 2026

stuartmorgan-g approved these changes Jun 22, 2026

View reviewed changes

Merge branch 'main' into camera-avfoundation-step1-darwin-rename

0776500

github-actions Bot removed the CICD Run CI/CD label Jun 22, 2026

stuartmorgan-g requested a review from bparrishMines June 22, 2026 17:30

stuartmorgan-g added the CICD Run CI/CD label Jun 22, 2026

Merge branch 'main' into camera-avfoundation-step1-darwin-rename

ad7826c

flutter-dashboard Bot removed the CICD Run CI/CD label Jul 7, 2026

stuartmorgan-g added the CICD Run CI/CD label Jul 7, 2026

stuartmorgan-g requested a review from LouiseHsu July 7, 2026 15:27

stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Jul 14, 2026

bparrishMines approved these changes Jul 22, 2026

View reviewed changes

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 22, 2026

auto-submit Bot merged commit 5a80e0a into flutter:main Jul 22, 2026
89 checks passed

engine-flutter-autoroll mentioned this pull request Jul 24, 2026

Roll Packages from 8260a1e5670c to 69693296b8df (21 revisions) flutter/flutter#189983

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[camera_avfoundation] Move camera_avfoundation to Darwin#11847

[camera_avfoundation] Move camera_avfoundation to Darwin#11847
auto-submit[bot] merged 8 commits into
flutter:mainfrom
Mairramer:camera-avfoundation-step1-darwin-rename

Mairramer commented Jun 5, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Mairramer commented Jun 8, 2026

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Mairramer commented Jun 9, 2026

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g commented Jun 22, 2026

Uh oh!

okorohelijah commented Jul 16, 2026

Uh oh!

bparrishMines left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Mairramer commented Jun 5, 2026

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Mairramer commented Jun 8, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Mairramer commented Jun 9, 2026

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Jun 22, 2026

Uh oh!

okorohelijah commented Jul 16, 2026

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants