Skip to content

Add more scripts for closing-obsolete-issues skill - #9979

Open
srawlins wants to merge 2 commits into
flutter:masterfrom
srawlins:skill-script
Open

Add more scripts for closing-obsolete-issues skill#9979
srawlins wants to merge 2 commits into
flutter:masterfrom
srawlins:skill-script

Conversation

@srawlins

Copy link
Copy Markdown
Contributor

I was running with an agent using the 'close-obsolete-issues' skill and it kept making ad-hoc python scripts; I asked it to check them in as Dart scripts. This should make this task faster in the future.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces shell scripts with new Dart scripts (fetch_issues.dart and search_prs.dart) for fetching issues and searching PRs, and updates the SKILL.md documentation accordingly. The review feedback highlights a contradictory style constraint in SKILL.md caused by an accidental character replacement, and suggests robustness improvements in the Dart scripts, including validating command-line argument parsing, using idiomatic list pre-allocation, and handling potential JSON decoding exceptions.

Comment thread .agents/skills/closing-obsolete-issues/SKILL.md Outdated
Comment thread .agents/skills/closing-obsolete-issues/scripts/fetch_issues.dart
Comment thread .agents/skills/closing-obsolete-issues/scripts/fetch_issues.dart
Comment thread .agents/skills/closing-obsolete-issues/scripts/search_prs.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant