[video_player_videohole] Migrating from Platform Channels to Dart FFI - #1073
Open
gin7773 wants to merge 29 commits into
Open
[video_player_videohole] Migrating from Platform Channels to Dart FFI#1073gin7773 wants to merge 29 commits into
gin7773 wants to merge 29 commits into
Conversation
gin7773
marked this pull request as draft
July 28, 2026 10:38
…tore the return type of restore.
- Add nlohmann/json single-header library to tizen/third_party/ - Replace handwritten JSON parser with nlohmann/json in ParseJsonMap() - Simplify ParseCreateMessage() to use json library directly - Add EncodableValueFromJson() helper for JSON to EncodableValue conversion This change improves JSON parsing reliability by supporting: - Escape characters in strings - Nested objects and arrays - Unicode characters - Proper error handling with parse_error exceptions Co-Authored-By: Cline SR
- Add UnregisterAllPlayerEventPorts() function in video_player.cc - Add ffi_unregister_all_player_event_ports() FFI wrapper - Add Dart bindings in ffi_messages.g.dart - Call unregisterAllPlayerEventPorts() in init() to clean up ports on hot restart This fix prevents Dart port leaks when the Dart VM is restarted (e.g., hot restart during development) while the native process continues. Co-Authored-By: Cline SR
- Fix FFI event port symbol name mismatch (ffi_register_dart_port) - Call Prepare() after RestorePlayer for two-phase initialization - Return true from Play() when already playing (idempotent) - Remove duplicate play() call in restored event handler Co-Authored-By: Cline SR
xiaowei-guan
self-requested a review
July 30, 2026 09:24
gin7773
marked this pull request as ready for review
August 5, 2026 08:19
xiaowei-guan
reviewed
Aug 5, 2026
| ",\"durationRange\":[" + | ||
| std::to_string(duration_pair.first) + "," + | ||
| std::to_string(duration_pair.second) + "]}"; | ||
| return strdup(duration_json.c_str()); |
Contributor
There was a problem hiding this comment.
Memory leak: ffi_get_duration returns strdup-allocated string, but ffi_get_track_info also returns strdup-allocated string — Dart side must call ffi_free_string
ffi_get_duration()returnsstrdup(duration_json.c_str())— caller mustfree().ffi_get_track_info()returnsstrdup(j.dump().c_str())— caller mustfree().- Dart side:
duration()andgetTrackInfo()correctly callbindings._ffiFreeString(ptr)infinallyblocks. ✅ Verified correct. - However:
ffi_get_duration()returnsstrdup("-1")when player not found. The Dart side checksif (jsonString == '-1')and throws, but thefinallyblock does free it. ✅ OK.
xiaowei-guan
reviewed
Aug 5, 2026
- Move all FFI function implementations from video_player_tizen_plugin.cc to ffi_messages.cc - Add ffi_prepare() function that was missing - Use dependency injection pattern (ffi_set_plugin_registrar) for clean boundaries - Keep video_player_tizen_plugin.cc minimal (plugin registration only) Co-Authored-By: Cline SR
> > 1. Fix potential deadlock in PostEventToDart > - Copy port number under lock, then release lock BEFORE calling Dart_PostCObject_DL > - Use explicit scope block to ensure lock is released immediately > - Prevents deadlock if Dart_PostCObject_DL blocks or callbacks into native code > > 2. Remove dead code (player_index variable) > - player_index in video_player.cc is no longer used > - ID generation moved to media_player.cc (player_id_counter) > > Co-Authored-By: Cline SR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes: