[tizen_app_control] Update integration tests - #1068
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the integration tests for tizen_app_control by relaxing the matched app IDs assertion, adding a test for URI and MIME round-trips, and verifying exact string list extra data. Feedback highlights a tautological assertion on list length that should be replaced with a type check, and a potential race condition in the new test where the broadcast stream should be listened to before triggering the launch request.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| * Update minimum Flutter and Dart version to 3.13 and 3.1. | ||
| * Update code format. | ||
| * Add YouTube app launch to the example. | ||
| * Update integration tests: relax the `getMatchedAppIds` assertion to accept zero or more results, add a test for `uri`/`mime` round-trip, and verify the exact values of `List<String>` extra data. |
There was a problem hiding this comment.
| * Update integration tests: relax the `getMatchedAppIds` assertion to accept zero or more results, add a test for `uri`/`mime` round-trip, and verify the exact values of `List<String>` extra data. | |
| * Update integration tests. |
- Relax the 'Can find matching applications' assertion from isNotEmpty to greaterThanOrEqualTo(0): app_control_foreach_app_matched returns APP_CONTROL_ERROR_NONE with an empty list when no apps match, so an empty result is not an error. - Add 'Can send and receive request with uri and mime': verifies that uri and mime fields are correctly transmitted and received (the existing test only covered the null case). - Strengthen the String list extra data assertion in 'Omit invalid extra data' to check exact values instead of just isNotEmpty. Validated on RPI4 and TV emulator (T-samsung-10.0-x86_64): 7 tests, all pass. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bb56e21 to
fea3a31
Compare
2 participants
Validated on RPI4 and TV emulator (T-samsung-10.0-x86_64): 7 tests, all pass.