fix: default searchable dropdown text style to titleMedium #99 - #156
Open
AzazelSensei wants to merge 1 commit into
Open
fix: default searchable dropdown text style to titleMedium #99#156AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Match TextField / FormBuilderTextField by using Theme.of(context).textTheme.titleMedium when dropdownSearchTextStyle is omitted. Same default on the multi-select field.
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 56.13% 56.54% +0.40%
==========================================
Files 5 5
Lines 212 214 +2
==========================================
+ Hits 119 121 +2
Misses 93 93 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Maybe need to test the last version of dropdown_search to verify if this is already solved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Close #99
Solution description
dropdownSearchTextStylewas passed through as-is, so the selected value used dropdown_search's own default instead ofTheme.of(context).textTheme.titleMedium(whatTextField/FormBuilderTextFielduse).I set that as the fallback on
FormBuilderSearchableDropdownandFormBuilderSearchableMultiSelectDropdown. PassingdropdownSearchTextStylestill wins.Screenshots or Videos
To Do