Skip to content

fix: default searchable dropdown text style to titleMedium #99 - #156

Open
AzazelSensei wants to merge 1 commit into
flutter-form-builder-ecosystem:mainfrom
AzazelSensei:fix-99-searchable-text-style
Open

fix: default searchable dropdown text style to titleMedium #99#156
AzazelSensei wants to merge 1 commit into
flutter-form-builder-ecosystem:mainfrom
AzazelSensei:fix-99-searchable-text-style

Conversation

@AzazelSensei

Copy link
Copy Markdown
Contributor

Connection with issue(s)

Close #99

Solution description

dropdownSearchTextStyle was passed through as-is, so the selected value used dropdown_search's own default instead of Theme.of(context).textTheme.titleMedium (what TextField / FormBuilderTextField use).

I set that as the fallback on FormBuilderSearchableDropdown and FormBuilderSearchableMultiSelectDropdown. Passing dropdownSearchTextStyle still wins.

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Match TextField / FormBuilderTextField by using
Theme.of(context).textTheme.titleMedium when dropdownSearchTextStyle
is omitted. Same default on the multi-select field.
@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.54%. Comparing base (493cd41) to head (0210f16).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   56.13%   56.54%   +0.40%     
==========================================
  Files           5        5              
  Lines         212      214       +2     
==========================================
+ Hits          119      121       +2     
  Misses         93       93              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@deandreamatias

Copy link
Copy Markdown
Contributor

Maybe need to test the last version of dropdown_search to verify if this is already solved.
Force the style is not the way I guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FormBuilderSearchableDropdown]: Default dropdownSearchTextStyle default TeextStyle schould be Theme.of(context).textTheme.titleMedium

2 participants