Repository navigation
Record the content service and job runner choices in the backend spec - #2753
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2752
Records in
docs/planning/backend-technical-spec.mdwhat #2747 (content service) and #2748 (job runner) shipped and the spec did not say, each checked against the merged code. Section 4.2 getsfallbacksas a reserved name. Section 4.4 getsPatchAsync, the two new exceptions,SystemOperation, how a refusal differs from not found, and the audit principal. Section 4.8 gets the global-type write rule and the shared-field rule. Section 4.12 gets the actor and principal rule,cms_recurring_job.type,AddRecurringAsync,IJobDeadLetters, job registration and the claim index. Section 9.2 lists #2749, #2750 and #2751. No other decision is changed.Dependencies: none.
Acceptance
markdownlint-cli2reports no issuesDisagreements left as written
payload json.ISJSONthere refuses a scalar, so enqueueing anIJob<int>orIJob<string>fails while SQLite and PostgreSQL accept it. Validate and complete the PostgreSQL and SQL Server providers #2711 has to choose between a wrapper object and a rule that payloads are objects.UpdateAsync(id, entry, expectedVersion). EveryIContentServicemethod takes the type name first. I wrote that in the new contract paragraph and left the table's short forms.HiddenandReadOnlyfields instead, and refuses any other field outside the grants. The new contract paragraph records the shipped rule.