Repository navigation
Record the rich text editor contract in the specification - #2726
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2725
Section 4.1 now lists the rich text contracts (
IRichTextRenderer,IRichTextNodeRenderer,IRichTextNodeContext,RichTextRenderOptions,RichTextFormats) in theFluentCMS.Schemarow. Section 4.2 gains a "Rich text editor contract" paragraph: the stored node and mark names follow Tiptap, documents using stock ProseMirror names (image,bullet_list,strong) are rejected by validation, and the three FluentCMS additions (media,inlineBlock,entryLink) are listed with their attributes as read fromRichTextParser. The sample now uses[Relation(Reverse = "articles")]and the FormerNames mention uses[FormerNames("subtitle")].Choices beyond the issue:
"articles", because it is unambiguous insideArticle; the attribute reader camel-cases the value, so it gives the same schema asnameof(Samples.Author.Articles).level,start,language,href,title,target), not only the three additions, and the stock names rejected, so the editor team has the full set in one place.video_urlmoved tocms_articlebecause the sample'sVideoUrlis not localizable.Verification: the 4.2 sample classes were copied into a scratch file in
tests/FluentCMS.Core.Tests(with stubAuthor,Tag,ArticleCategory,QuoteBlock,GalleryBlock) anddotnet build -c Release -warnaserrorpassed with 0 warnings and 0 errors. With the oldnameof(Author.Articles)the same build fails with CS1061. The scratch file is deleted and not committed.Dependencies: none.