Skip to content

1.0: follow from rewrite cache-control - #681

Merged
Watson1978 merged 1 commit into
fluent:1.0from
kenhys:fixup-cache-control
Aug 13, 2026
Merged

1.0: follow from rewrite cache-control#681
Watson1978 merged 1 commit into
fluent:1.0from
kenhys:fixup-cache-control

Conversation

@kenhys

@kenhys kenhys commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

The following /assets/, /1.0/assets/ and /0.12/assets/ were covered in [[headers]] rule, but hidden .gitbook/assets rule were not covered yet.
Thus, cache-control header is not changed for ".gitbook/assets" targets.

e.g. .gitbook/assets cache-control should be fixed in the following use-case.

curl -sI https://docs.fluentd.org/assets/kafka.png |grep -i 'cache-control'
cache-control: public,max-age=604800
curl -sI https://docs.fluentd.org/.gitbook/assets/kafka.png |grep -i 'cache-control'
cache-control: public,max-age=0,must-revalidate

The following /assets/, /1.0/assets/ and /0.12/assets/
were covered in [[headers]] rule, but hidden .gitbook/assets
rule were not covered yet.
Thus, cache-control header is not changed for ".gitbook/assets"
targets.

e.g. .gitbook/assets cache-control should be fixed in the following use-case.

> curl -sI https://docs.fluentd.org/assets/kafka.png |grep -i 'cache-control'
cache-control: public,max-age=604800
> curl -sI https://docs.fluentd.org/.gitbook/assets/kafka.png |grep -i 'cache-control'
cache-control: public,max-age=0,must-revalidate

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@netlify

netlify Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deploy Preview for fluentd-docs ready!

Name Link
🔨 Latest commit 7337e4e
🔍 Latest deploy log https://app.netlify.com/projects/fluentd-docs/deploys/6a7d381c91fa09000898ec58
😎 Deploy Preview https://deploy-preview-681--fluentd-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kenhys
kenhys requested a review from Watson1978 August 13, 2026 03:25
@Watson1978
Watson1978 merged commit ce3e0a1 into fluent:1.0 Aug 13, 2026
6 checks passed
@kenhys
kenhys deleted the fixup-cache-control branch August 13, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants