Repository navigation
feat(fluentbit): add workers option to http output - #2076
Open
l1ghtman2k wants to merge 1 commit into
Open
l1ghtman2k wants to merge 1 commit into
l1ghtman2k wants to merge 1 commit into
Conversation
Expose the generic Fluent Bit Workers output option on the http output, as already done for syslog, s3, firehose, loki and others. Regenerates deepcopy, CRDs, manifests and docs, and adds unit tests covering Params, Load and LoadAsYaml rendering. Signed-off-by: aibek <aibek.zhil@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a
workersoption to the Fluent Bit http output plugin, mirroring how it is already exposed on the syslog (#1874), s3 (#1647), firehose (#1954), loki and other outputs.A single-threaded http output tops out at roughly 2.5k records/s per node in our deployment. Fluent Bit's generic
Workersoutput option (https://docs.fluentbit.io/manual/administration/multithreading) is the documented knob for this, but the operator did not expose it forout_http.Changes:
Workers *int32(json:"workers,omitempty") onoutput.HTTP, rendered asworkersinParamsconfig/crd/bases,charts/fluent-operator/crds,charts/fluent-operator-fluent-bit-crds/templates),manifests/setup/setup.yamlanddocs/plugins/fluentbit/output/http.mdTestHTTP_Paramsextended; newTestHTTPOutputWithWorkers_Load/_LoadAsYamlasserting the rendered[Output]block / YAML sectionWhich issue(s) this PR fixes:
None
Does this PR introduced a user-facing change?
Additional documentation, usage docs, etc.: