Repository navigation
chore: run the database tests, a gofmt check and a Docker build in CI - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI had no database, so every
internal/datatest skipped there while still printingok.postgres:16service,DATABASE_URL, and ago run ./cmd/api --migrate-onlystep before the tests (the tests do not migrate). That step also fails the job if the database is unreachable, instead of a silent skip.test -z "$(gofmt -l .)".push: falseand no registry login, so a brokenDockerfileis caught before the merge. Pushes behave as before.AGENTS.mdandCONTRIBUTING.mdupdated to match.The same recipe (throwaway
postgres:16,--migrate-only,go test -race ./...) passes locally with no test skipped.