Repository navigation
fix: stop the HTTP server before the background services on shutdown - #57
Merged
Merged
Conversation
Owner
Author
|
Review: OK to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On SIGTERM the scheduler and the subscription and OPML services were stopped first, and the HTTP server only afterwards. Requests arriving in between started background work on a context that was already cancelled: a new subscription's import failed at once and counted a failure against a healthy feed, and
wg.Gocould run afterwg.Wait.srv.Shutdownnow runs first; its error is kept and sent once the services have stopped. The 20-second budget is unchanged.No new test: the change is a reorder inside the signal goroutine.
go vetandgo test -race ./cmd/apipass.Closes #40