Repository navigation
fix: stop the tabindex cleanup rule from deleting real article content - #55
Merged
Merged
Conversation
Owner
Author
|
Review: OK to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cleanup rule removed every element carrying
tabindex="-1". Sites put that attribute on real content (GitHub on every heading, many themes on<main>or on the<div id="content">a skip link points to), so headings or whole article bodies were dropped.<div tabindex="-1">with noid, which is what the Le Monde promo blocks it was written for look like. A div with an id is a skip-link target and is kept.<main>and a<div id="content">withtabindex="-1"all survive. The existing case and the Le Monde golden file still pass.Tested with
go vetandgo test -race ./internal/readability.Closes #38