Repository navigation
fix: recover panics inside the article import instead of crashing the server - #54
Merged
Merged
Conversation
Owner
Author
|
Review: OK to merge.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import started after a subscription ran
ImportArticlesForSubscriberson a goroutine with norecover(), so a panic in the HTML parsing took the whole process down. Only the scheduler path was protected.ImportArticlesForSubscribersnow recovers the panic itself, logs it, marks the feed failed through the existingmarkFailed, and returns it as an error. Both callers are covered from one place.processFeedno longer carries its ownrecover.TestImportArticlesForSubscribersRecoversPanic(no database needed).Tested with
go build ./... && go vet ./... && go test -race ./internal/service ./cmd/apiand staticcheck.Closes #19