Repository navigation
Record a delete reason when tasks and activities end without completing - #4332
Open
BertMatthys wants to merge 3 commits into
Open
BertMatthys wants to merge 3 commits into
BertMatthys wants to merge 3 commits into
Conversation
…with its parent case
… condition is met The remaining activities ended with a null delete reason, like completed ones. They are now cancelled with the delete reason "adhoc subprocess completed": ACTIVITY_CANCELLED is dispatched with the completing activity as cause, and the child process of a call activity ends as cancelled. They are deleted before the completing activity is left, so all its outgoing sequence flows are still taken.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some engine paths end a task or activity with a null delete reason, so history and listeners cannot tell it from a completed one:
cmmn-state-transition-delete-case.event subprocess(<startEventId>), with the start event as cancel activity, like the other event sub-processes.DeleteReason.ADHOC_SUBPROCESS_COMPLETED.ACTIVITY_CANCELLEDis dispatched with the completing activity as cause, and the child process of a call activity ends as cancelled instead of completed. They are deleted before the completing activity is left, so all its outgoing sequence flows are still taken.Check List: